New issue
Advanced search Search tips

Issue 717297 link

Starred by 1 user
Status: Verified
Owner:
ntfschr@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 707481



Sign in to add a comment

fails for mobile layout chrome_security_exploit_browsertest

Project Member Reported by ntfschr@chromium.org, May 1 2017 
The tests in chrome_security_exploit_browsertest.cc succeed for the Desktop layout, but will fail for the mobile layout.

The tests fail because the mobile layout has one fewer newline.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f4dd56083fb4ad41a8bc53bad9a24fa137b6f1

commit d9f4dd56083fb4ad41a8bc53bad9a24fa137b6f1
Author: ntfschr <ntfschr@chromium.org>
Date: Tue May 02 16:21:27 2017

ChromeSecurityExploitBrowserTest: normalize whitespace for tests

No change to production logic.

The mobile layout an desktop layout for this page differ slightly in
terms of white space (one layout has two newlines while one has only
one). This causes failures when testing against the mobile layout.

To address this, this CL squashes multiple newlines into a single one.

BUG= 717297 

Review-Url: https://codereview.chromium.org/2851423002
Cr-Commit-Position: refs/heads/master@{#468669}

[modify] https://crrev.com/d9f4dd56083fb4ad41a8bc53bad9a24fa137b6f1/chrome/browser/chrome_security_exploit_browsertest.cc

Comment 2 by ntfschr@chromium.org, May 2 2017

Status: Fixed (was: Assigned)

Comment 3 by ntfschr@chromium.org, Aug 24

Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.
►

Sign in to add a comment