New issue
Advanced search Search tips

Issue 717285 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor DefaultAudioDestinationNode::setChannelCount()

Project Member Reported by hongchan@chromium.org, May 1 2017

Issue description

See:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp?dr=CSs&l=136

When the user sets the new channel count, the code does this:

...
destination_->Stop();
CreateDestination();
destination_->Start();
...

This triggers the re-construction of AudioRenderSink, FIFO, AudioBuses and WebThread class. Too much for the simple channel count change.

Consider refactoring this.
 

Sign in to add a comment