New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717283 link

Starred by 1 user
Status: Fixed
Owner:
█ catmulli...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
rdevlin....@chromium.org
█ mgiuca@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Permission warnings for settings overrides strips `www` with custom code

Project Member Reported by lgar...@chromium.org, May 1 2017 
It seems that `settings_overrides_handler.cc` implements its own `FormatUrlForDisplay()` function to strip the `www` prefix. The relevant dialog is not critically short on space compared to other places we show origins, so I don't think it should be doing this.

Comment 1 by lgar...@chromium.org, May 1 2017

Components: Platform>Extensions UI>Security>UrlFormatting
Labels: -Pri-3 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
Alternatively, the code should at least call url_formatter::StripWWW() [1].
However, there are very few callers for that function, and they all seem to be based around use cases that strictly need that functionality (rather than formatting things for user readability).

rdevlin.cronin@, could you triage?

[1] https://cs.chromium.org/chromium/src/components/url_formatter/url_formatter.h?q=formatUrl&dr=CSs&l=141

Comment 2 by lgar...@chromium.org, May 1 2017

Labels: Team-Security-UX

Comment 3 by rdevlin....@chromium.org, Aug 29 2017

Cc: rdevlin....@chromium.org
Owner: catmulli...@chromium.org
This is somewhat similar to other code catmullings@ has been looking at.

Comment 4 by catmulli...@chromium.org, Aug 31 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77b0453156f99cfcef1918b13a943a2780178882

commit 77b0453156f99cfcef1918b13a943a2780178882
Author: Catherine Mullings <catmullings@chromium.org>
Date: Tue Sep 05 17:03:57 2017

Replace custom code to strip 'www' in setting override permission warning

SettingsOverrideHandler::FormatUrlForDisplay() implements a custom way to
strip a 'www' prefix from an origin. Instead the method should use the
existing function, url_formatter:StripWWW(). This CL makes this change.

Bug:  717283 
Change-Id: I273bec6b5677f39d45298b334b1c66bde9cc1849
Reviewed-on: https://chromium-review.googlesource.com/646955
Commit-Queue: catmullings <catmullings@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499658}
[modify] https://crrev.com/77b0453156f99cfcef1918b13a943a2780178882/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

Comment 6 by catmulli...@chromium.org, Sep 5 2017

Status: Fixed (was: Started)
►

Sign in to add a comment