Overriding the effective connection type should also override RTT and throughput values |
||||||
Issue descriptionCurrently, it is possible to override the effective connection type returned by NQE using field trial and flag. However, that overriding does not affect the RTT/bandwidth estimates returned by NQE. We should make sure that overriding the effective connection type should also override RTT and throughput estimates. This would make it easier for API consumers to test features that vary on RTT and throughput values.
,
May 8 2017
,
May 16 2017
,
May 16 2017
,
May 17 2017
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15fb9f6cd7ef8820ca37a1da0e38b66975ace717 commit 15fb9f6cd7ef8820ca37a1da0e38b66975ace717 Author: tbansal <tbansal@chromium.org> Date: Thu May 18 12:05:52 2017 Override RTT and throughput when ECT is overridden When Effective Connection Type (ECT) is overridden, then HTTP RTT, transport RTT and throughput are also overridden. BUG= 717278 Review-Url: https://codereview.chromium.org/2890683002 Cr-Commit-Position: refs/heads/master@{#472773} [modify] https://crrev.com/15fb9f6cd7ef8820ca37a1da0e38b66975ace717/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/15fb9f6cd7ef8820ca37a1da0e38b66975ace717/net/nqe/network_quality_estimator.h [modify] https://crrev.com/15fb9f6cd7ef8820ca37a1da0e38b66975ace717/net/nqe/network_quality_estimator_unittest.cc
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15fb9f6cd7ef8820ca37a1da0e38b66975ace717 commit 15fb9f6cd7ef8820ca37a1da0e38b66975ace717 Author: tbansal <tbansal@chromium.org> Date: Thu May 18 12:05:52 2017 Override RTT and throughput when ECT is overridden When Effective Connection Type (ECT) is overridden, then HTTP RTT, transport RTT and throughput are also overridden. BUG= 717278 Review-Url: https://codereview.chromium.org/2890683002 Cr-Commit-Position: refs/heads/master@{#472773} [modify] https://crrev.com/15fb9f6cd7ef8820ca37a1da0e38b66975ace717/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/15fb9f6cd7ef8820ca37a1da0e38b66975ace717/net/nqe/network_quality_estimator.h [modify] https://crrev.com/15fb9f6cd7ef8820ca37a1da0e38b66975ace717/net/nqe/network_quality_estimator_unittest.cc
,
May 18 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, May 1 2017Labels: OS-All