New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717266 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 725132



Sign in to add a comment

[Findit] Fix bug in StartTryJobOnDemandPipeline

Project Member Reported by chanli@chromium.org, May 1 2017

Issue description

In StartTryJobOnDemandPipeline, Findit first checks if a try job is needed. If needed, Findit will process swarming reruns and trigger try jobs. Which means if Findit decides a try job is not needed, the swarming reruns triggered earlier will not be processed and the WfSwarmingTask entity will not be updated.

We should fix this and update Findit results with swarming rerun results regardless.
 

Comment 1 Deleted

Comment 2 by st...@chromium.org, May 4 2017

Just curious, is the CL relevant to this bug? 
I accidentally linked the wrong bug (kept too many tabs open...) I have deleted the comment

Comment 4 by chanli@chromium.org, May 22 2017

Blocking: 725132
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dbe8aa7fb595a139db2a3efa47f214cc253faf42

commit dbe8aa7fb595a139db2a3efa47f214cc253faf42
Author: Chan <chanli@chromium.org>
Date: Tue May 30 20:28:36 2017

Process swarming reruns result before checking if needing try job.

Currently in Findit pipeline, swarming tasks are triggered early, but it will only
process tasks result if a try job is needed. This leads to some analyses not updated
because they don't need or can't have try jobs.

The fix move the pipelines which processed tasks result and update analysis about flaky information
before start_try_job_on_demand_pipeline.

Bug:  717266 
Change-Id: I9b88676b917042fb9876430d0fb9709b60317b31
Reviewed-on: https://chromium-review.googlesource.com/513463
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/process_swarming_task_result_pipeline.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/update_analysis_with_flake_info_pipeline.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
[add] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/process_swarming_tasks_result_pipeline.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/test/update_analysis_with_flake_info_pipeline_test.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/analyze_build_failure_pipeline.py
[add] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/test/process_swarming_tasks_result_pipeline_test.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/model/base_swarming_task.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/schedule_test_try_job_pipeline.py
[modify] https://crrev.com/dbe8aa7fb595a139db2a3efa47f214cc253faf42/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py

Comment 6 by chanli@chromium.org, May 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment