New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 717262 link

Starred by 3 users
Status: Archived
Owner:
steve...@chromium.org
Closed: May 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ gkihumba@google.com
harpreet@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cannot configure network info for Ethernet/WiFi manually.

Project Member Reported by aashuto...@chromium.org, May 1 2017 
Chrome Version: <From about:version: Google Chrome 59.0.3071.33>
Chrome OS Version: <From about:version: Platform 9460.18.0>
Chrome OS Platform: <Candy>
Network info: Ethernet and WiFi

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Login to the device.
(2) Connect to Ethernet or WiFi hotspot
(3) Go to Chrome://setting/networks and try to configure IP address, subnet mask, Gateway, DNS manually. 

Expected Result:
User should be able to configure IP address, subnet mask, Gateway, DNS manually. 

Actual Result: No option to configure the above parameters manually in new MD settings page

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by steve...@chromium.org, May 1 2017

Labels: -Pri-2 Pri-1
Status: Started (was: Untriaged)
To clarify this:

Visit the details page for a network and click to expand the 'Network' section.

Expected:
* User should be able to configure IP address, etc.

Actual:
* The Network section is empty.

This appears to have broken at some point recently, I will investigate.

Comment 2 by steve...@chromium.org, May 3 2017

Cc: steve...@chromium.org kavvaru@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 717943  has been merged into this issue.

Comment 4 by steve...@chromium.org, May 4 2017

Labels: Merge-Request-59
Status: Fixed (was: Started)

Comment 5 by gkihumba@google.com, May 4 2017

Labels: Merge-Approved-59
Project Member

Comment 6 by bugdroid1@chromium.org, May 4 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a34ad21983863dcfd0554e6b129257d936e1d4

commit a8a34ad21983863dcfd0554e6b129257d936e1d4
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu May 04 21:50:18 2017

MD Settings: Internet: Fix IP config visibility

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG= 717262 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856023002
Cr-Commit-Position: refs/heads/master@{#469215}
(cherry picked from commit 1d11530a771298ce260f024b118864f66cdace4c)

Review-Url: https://codereview.chromium.org/2865543002 .
Cr-Commit-Position: refs/branch-heads/3071@{#409}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/a8a34ad21983863dcfd0554e6b129257d936e1d4/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/a8a34ad21983863dcfd0554e6b129257d936e1d4/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/a8a34ad21983863dcfd0554e6b129257d936e1d4/chrome/browser/resources/settings/internet_page/network_ip_config.html
[modify] https://crrev.com/a8a34ad21983863dcfd0554e6b129257d936e1d4/chrome/browser/resources/settings/internet_page/network_ip_config.js
[modify] https://crrev.com/a8a34ad21983863dcfd0554e6b129257d936e1d4/chrome/browser/resources/settings/internet_page/network_property_list.html
Project Member

Comment 7 by sheriffbot@chromium.org, May 5 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, May 9 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by steve...@chromium.org, May 9 2017

Labels: -Merge-Approved-59

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment