New issue
Advanced search Search tips

Issue 717254 link

Starred by 1 user
Status: Verified
Owner:
ntfschr@chromium.org
Closed: May 2017
Cc:
edwardjung@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 707481



Sign in to add a comment

errorpage_browsertest fails for mobile layout

Project Member Reported by ntfschr@chromium.org, May 1 2017 
The tests in errorpage_browsertest.cc succeed for the Desktop layout, but will fail for the mobile layout.

The tests fail when checking IsDisplayingText(..., GetShowSavedButtonLabel()). The test uses a case-sensitive check (String.prototype.indexOf), but mobile and desktop layout differ in terms of capitalization (mobile makes buttons all-caps, desktop doesn't).

Performing a case-insensitive comparison should be sufficient to fix the test. This should be safe as long as the interstitial doesn't have the same strings appear twice with different cases.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d82d39ab1671da7e27edb1e433eb413f1a4576a

commit 1d82d39ab1671da7e27edb1e433eb413f1a4576a
Author: ntfschr <ntfschr@chromium.org>
Date: Tue May 02 16:19:44 2017

ErrorPage: use case-insensitive check for text

No change to production logic.

This CL uses a case-insensitive check to see if text is included in the
document body.

The mobile layout fully capitalizes buttons, while the desktop
layout keeps things in their original case. Since the layouts differ in
terms of case, it's necessary to use case-insensitive comparisons,
otherwise IsDisplayingText() will fail for GetShowSavedButtonLabel().

BUG= 717254 

Review-Url: https://codereview.chromium.org/2850293002
Cr-Commit-Position: refs/heads/master@{#468667}

[modify] https://crrev.com/1d82d39ab1671da7e27edb1e433eb413f1a4576a/chrome/browser/net/errorpage_browsertest.cc

Comment 2 by ntfschr@chromium.org, May 2 2017

Status: Fixed (was: Assigned)

Comment 3 by ntfschr@chromium.org, Aug 24

Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.
►

Sign in to add a comment