New issue
Advanced search Search tips

Issue 717252 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

rotating device shouldn't show rotate notification.

Project Member Reported by osh...@chromium.org, May 1 2017

Issue description

Seen on ToT, but not on m58. Probably regression either on 59 or 60.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31b81d4cf8b6a063391839816c82fc61c8272e53

commit 31b81d4cf8b6a063391839816c82fc61c8272e53
Author: afakhry <afakhry@chromium.org>
Date: Wed May 03 18:57:48 2017

Avoid Showing rotation change notification when source is accelerometer

BUG= 717252 
TEST=Manually rotate device with accelerometer and observe there's no notification

Review-Url: https://codereview.chromium.org/2853113005
Cr-Commit-Position: refs/heads/master@{#469058}

[modify] https://crrev.com/31b81d4cf8b6a063391839816c82fc61c8272e53/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/31b81d4cf8b6a063391839816c82fc61c8272e53/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/31b81d4cf8b6a063391839816c82fc61c8272e53/testing/buildbot/filters/ash_mus_unittests.filter

Labels: Merge-Request-59
Labels: Merge-Approved-59
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509be1fc5de47ffb8455e4dc2b73a055462e1122

commit 509be1fc5de47ffb8455e4dc2b73a055462e1122
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu May 04 03:14:57 2017

[Merge to M59] Avoid Showing rotation change notification when source is accelerometer

TBR=oshima@chromium.org
BUG= 717252 
TEST=Manually rotate device with accelerometer and observe there's no notification

Review-Url: https://codereview.chromium.org/2853113005
Cr-Commit-Position: refs/heads/master@{#469058}
(cherry picked from commit 31b81d4cf8b6a063391839816c82fc61c8272e53)

Review-Url: https://codereview.chromium.org/2861953002 .
Cr-Commit-Position: refs/branch-heads/3071@{#392}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/509be1fc5de47ffb8455e4dc2b73a055462e1122/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/509be1fc5de47ffb8455e4dc2b73a055462e1122/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/509be1fc5de47ffb8455e4dc2b73a055462e1122/testing/buildbot/filters/ash_mus_unittests.filter

Status: Fixed (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, May 5 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-59
Already merged.
Status: Verified (was: Fixed)
9460.42.0, 59.0.3071.57

Sign in to add a comment