New issue
Advanced search Search tips

Issue 717244 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: NTP sometimes renders as a black texture

Project Member Reported by mthiesse@chromium.org, May 1 2017

Issue description

Sometimes when we enter VR on the NTP, the texture doesn't render and we just see a black rectangle.
 
Owner: mthiesse@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e26a4859564edfca90ad1919a83a6e43aed2a9eb

commit e26a4859564edfca90ad1919a83a6e43aed2a9eb
Author: mthiesse <mthiesse@chromium.org>
Date: Fri May 19 19:01:03 2017

VR: Fix invalidation race viewing native pages.

If the NativePage finishes drawing before we connect a surface for it to draw into, then it won't redraw into the surface unless we invalidate it.

We were only partially handling this previously, and weren't invalidating as much as we needed to.

This also fixes a possible race that could trigger unnecessary recreation of our content surface when switching between NativePages and WebContents.

BUG= 717244 

Review-Url: https://codereview.chromium.org/2894903002
Cr-Commit-Position: refs/heads/master@{#473265}

[modify] https://crrev.com/e26a4859564edfca90ad1919a83a6e43aed2a9eb/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/e26a4859564edfca90ad1919a83a6e43aed2a9eb/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/e26a4859564edfca90ad1919a83a6e43aed2a9eb/chrome/browser/android/vr_shell/vr_shell.h

Status: Fixed (was: Assigned)

Sign in to add a comment