New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717227 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 717402
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

26.9% regression in memory.top_10_mobile_stress at 467950:467964

Project Member Reported by nzolghadr@chromium.org, May 1 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=717227

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgso6IuQoM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Cc: land...@opera.com
Owner: land...@opera.com

=== Auto-CCing suspected CL author landell@opera.com ===

Hi landell@opera.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : landell
  Commit : cce7ad62c6fc4ee4c7cd1b32c2f1bb77c5f66dc0
  Date   : Fri Apr 28 12:07:38 2017
  Subject: Avoid sending double responding close control frames in WebSockets

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/background/after_http_www_amazon_com_gp_aw_s_k_nexus
  Change       : 4.95% | 11209386.6667 -> 10654208.0

Revision             Result                  N
chromium@467949      11209387 +- 505202      6      good
chromium@467957      11935744 +- 514109      6      good
chromium@467961      12228608 +- 187322      6      good
chromium@467963      11956907 +- 496999      6      good
chromium@467964      10654208 +- 493257      6      bad       <--

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980765436994060576

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4910819810213888


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by land...@opera.com, May 17 2017

Sorry for missing this regression bug. What is expected of me in this?

I don't have a setup for working with android builds so it will be hard for me to investigate more. Seems also as some of the increase has been sorted out since this landed.

The regressions seem to have mostly gone away; I kicked off a few more bisects to see if this is all your CL.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, May 17 2017

Mergedinto: 717402
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : delphick
  Commit : c41d3c785c5179a38e54c6c80ea63d56cc7cfd12
  Date   : Fri Apr 28 11:50:09 2017
  Subject: Restore one millisecond minimum timeout for setTimeout.

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/foreground/https_www_google_co_uk_hl_en_q_science
  Change       : 11.43% | 21458069.1429 -> 23735219.1111

Revision             Result                    N
chromium@467953      21458069 +- 664430        14      good
chromium@467961      20883729 +- 3782946       9       good
chromium@467962      23699469 +- 7157127       9       bad       <--
chromium@467963      23141255 +- 10835352      14      bad
chromium@467965      23251572 +- 6632395       9       bad
chromium@467968      22876985 +- 9364797       14      bad
chromium@467983      23735219 +- 3486119       9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979346405762041056

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5544128961576960


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, May 17 2017

Cc: herb@google.com
Owner: herb@google.com

=== Auto-CCing suspected CL author herb@google.com ===

Hi herb@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Herb Derby
  Commit : 4b32ab1b7cac09f42b0867f6c63cd8656dd9918d
  Date   : Thu Apr 27 19:47:21 2017
  Subject: Add instrumentation into SkArenaAlloc.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/background/after_http_www_amazon_com_gp_aw_s_k_nexus
  Change       : 4.83% | 67532.0 -> 70796.0

Revision                             Result                  N
chromium@467921                      67532.0 +- 5237.72      6      good
chromium@467979                      70116.0 +- 0.0          6      good
chromium@467994                      70116.0 +- 0.0          6      good
chromium@467995                      70116.0 +- 0.0          6      good
chromium@467995,skia@a41d48b739      70116.0 +- 0.0          6      good
chromium@467995,skia@e3bd422faf      70116.0 +- 0.0          6      good
chromium@467995,skia@308e62416e      70116.0 +- 0.0          6      good
chromium@467995,skia@4b32ab1b7c      70796.0 +- 0.0          6      bad       <--
chromium@467996                      70796.0 +- 0.0          6      bad
chromium@467998                      70796.0 +- 0.0          6      bad
chromium@468001                      70796.0 +- 0.0          6      bad
chromium@468008                      70796.0 +- 0.0          6      bad
chromium@468036                      70796.0 +- 0.0          6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979346370385629520

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6353753214550016


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Sign in to add a comment