Since this benchmark doesn't use our supported harness, we want to remove it or move to tools/perf/contrib/ directory. jaydasika@ do you still need this benchmark?
Ping jaydasika@, we are trying to clean up all perf benchmarks this quarter.
Chatted with weiliangc@ about this. Both of us agree that since we are not checking this metric, it should be ok to remove it. tdresser : WDYT ?
Yup, SGTM.
Thanks, I will do the benchmark removal
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3f601b77244b4aecf31bcab65c7e80e9a847ad0 commit c3f601b77244b4aecf31bcab65c7e80e9a847ad0 Author: nednguyen <nednguyen@google.com> Date: Mon May 08 17:23:05 2017 Remove jitter benchmarks Bug: 717217 Change-Id: Icec9779f13e804df50f877c09f1e8d837120a8bf Reviewed-on: https://chromium-review.googlesource.com/498747 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#470031} [modify] https://crrev.com/c3f601b77244b4aecf31bcab65c7e80e9a847ad0/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/c3f601b77244b4aecf31bcab65c7e80e9a847ad0/testing/buildbot/chromium.perf.json [modify] https://crrev.com/c3f601b77244b4aecf31bcab65c7e80e9a847ad0/tools/perf/benchmark.csv [delete] https://crrev.com/bf593cdb72e7c8d5c564f24e0af0b746f19a1434/tools/perf/benchmarks/jitter.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d093ed4c8365e7fc53548d305c3e45543de1d37 commit 8d093ed4c8365e7fc53548d305c3e45543de1d37 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Mon May 08 19:40:37 2017 Roll src/third_party/catapult/ a71975b6f..adfbf3ec5 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a71975b6f89d..adfbf3ec5b00 $ git log a71975b6f..adfbf3ec5 --date=short --no-merges --format='%ad %ae %s' 2017-05-08 nednguyen Remove jitter metrics Created with: roll-dep src/third_party/catapult BUG= 717217 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib91a57b65d45f3e7fce13a34397978ad823bf823 Reviewed-on: https://chromium-review.googlesource.com/498629 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#470074} [modify] https://crrev.com/8d093ed4c8365e7fc53548d305c3e45543de1d37/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/678f212b42b2edbec40c34fa59a09b581567b25e commit 678f212b42b2edbec40c34fa59a09b581567b25e Author: nednguyen <nednguyen@google.com> Date: Wed May 10 12:26:13 2017 Remove jitter page set BUG= chromium:717217 TBR=jaydasika@chromium.org Review-Url: https://codereview.chromium.org/2873453005 Cr-Commit-Position: refs/heads/master@{#470539} [delete] https://crrev.com/bb3a8148c6f47151d82b7b9e490d8157d5e1fa6d/tools/perf/page_sets/jitter_pages.py [delete] https://crrev.com/bb3a8148c6f47151d82b7b9e490d8157d5e1fa6d/tools/perf/page_sets/jitter_test_cases/big_layer_jitter.html [delete] https://crrev.com/bb3a8148c6f47151d82b7b9e490d8157d5e1fa6d/tools/perf/page_sets/jitter_test_cases/child_jitter_with_parent.html [delete] https://crrev.com/bb3a8148c6f47151d82b7b9e490d8157d5e1fa6d/tools/perf/page_sets/jitter_test_cases/fixed.html [delete] https://crrev.com/bb3a8148c6f47151d82b7b9e490d8157d5e1fa6d/tools/perf/page_sets/jitter_test_cases/one_layer_jitter.html [delete] https://crrev.com/bb3a8148c6f47151d82b7b9e490d8157d5e1fa6d/tools/perf/page_sets/jitter_test_cases/two_layers_jitter.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6e70853b721052305e0de941e77b1f24ae21882 commit d6e70853b721052305e0de941e77b1f24ae21882 Author: Adrienne Walker <enne@chromium.org> Date: Thu Oct 25 23:52:16 2018 cc: Remove cdp.perf traces and jitter tracking code The jitter benchmark has been removed in issue 717217 , and nobody is looking at these metrics. Just cleaning up old code. Bug: 542813 , 717217 Change-Id: I2d4d806d30ef98873fbf64629ddf5fb883756ca6 Reviewed-on: https://chromium-review.googlesource.com/c/1299925 Reviewed-by: weiliangc <weiliangc@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602932} [modify] https://crrev.com/d6e70853b721052305e0de941e77b1f24ae21882/cc/trees/layer_tree_host.cc [modify] https://crrev.com/d6e70853b721052305e0de941e77b1f24ae21882/cc/trees/layer_tree_host_common.cc
Comment 1 by benhenry@chromium.org
, May 3 2017