Remove text_selection.* benchmarks or move them to tools/perf/contrib directory |
|||||
Issue descriptionThese benchmarks do not use any of our supported harness, so we want to either remove them or move to tools/perf/contrib directory. mfomitchev@: do you still care about these benchmarks? Note that they have been disabled on all platforms for a while.
,
May 5 2017
Ping mfomitchev@, we are trying to clean up all perf benchmarks this quarter.
,
May 5 2017
,
May 5 2017
+aelias, dtapuska, tdresser The benchmarks were disabled because they started failing on some bots. I couldn't figure out the failures easily, and I wasn't working on text selection anymore, so I never got back to it, and nobody took this over. At the time I couldn't reproduce the failures locally. Based on the testing I did, it seemed like these benchmarks got stuck at the very beginning of the test, and I couldn't explain the behavior. I have CCed some people who may be interested in keeping these benchmarks around. They were written to keep track of the text selection performance in Clank. If nobody steps up to revive them, then I guess we should move them to tools/perf/contrib directory.
,
May 5 2017
I think this is the kind of niche thing that can be worth fixing the performance of when it gives rise to user complaint, but not worth the burden of maintaining a benchmark for otherwise. This benchmark seems like just a straightforward proxy for main thread jank on these particular websites anyway.
,
May 9 2017
dtapuska@, tdresser@: are you ok with punting the benchmarks as well?
,
May 9 2017
SGTM.
,
May 9 2017
Thanks. I will do the work of removing this benchmark.
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84d4c846e8a9fe2dca982bd170ee4d35a949bdc4 commit 84d4c846e8a9fe2dca982bd170ee4d35a949bdc4 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Wed May 10 06:18:29 2017 Roll src/third_party/catapult/ 0e86ab1c3..9e43159fc (4 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0e86ab1c3ba9..9e43159fc62c $ git log 0e86ab1c3..9e43159fc --date=short --no-merges --format='%ad %ae %s' 2017-05-09 chiniforooshan tracing: Enable stream processing when input is large 2017-05-09 nednguyen Remove text_selection metrics 2017-05-09 benjhayden Add Google Analytics support to tr.b.Timing. 2017-05-09 nednguyen Remove mainthread_jank_stats metric Created with: roll-dep src/third_party/catapult BUG= 717215 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I057c0e571658b0ed2746814f842b892950a0c2a0 Reviewed-on: https://chromium-review.googlesource.com/501508 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#470499} [modify] https://crrev.com/84d4c846e8a9fe2dca982bd170ee4d35a949bdc4/DEPS
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf020bf21b6829abe5443dd46ffee60c7d32ec09 commit bf020bf21b6829abe5443dd46ffee60c7d32ec09 Author: nednguyen <nednguyen@google.com> Date: Wed May 10 11:15:54 2017 Remove text_selection.* benchmarks These benchmarks have been failing everywhere. They also don't fit into any supported harnesses, so we just remove them. BUG= 717215 Review-Url: https://codereview.chromium.org/2865923005 Cr-Commit-Position: refs/heads/master@{#470525} [modify] https://crrev.com/bf020bf21b6829abe5443dd46ffee60c7d32ec09/tools/perf/benchmark.csv [modify] https://crrev.com/bf020bf21b6829abe5443dd46ffee60c7d32ec09/tools/perf/benchmarks/benchmark_smoke_unittest.py [delete] https://crrev.com/f588c3bceb117e579068d1b4b3bb4153642d941d/tools/perf/benchmarks/text_selection.py [delete] https://crrev.com/f588c3bceb117e579068d1b4b3bb4153642d941d/tools/perf/page_sets/text_selection_sites.py
,
May 10 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by benhenry@chromium.org
, May 3 2017