Remove blink_style.* benchmark or move it to tools/perf/contrib/ directory |
|||||||||
Issue descriptionThese benchmarks doesn't use any of our supported harnesses, hence should be moved to tools/perf/contrib/ directory or be removed. dstockwell@ was the last one who touches this. Do you still need these benchmarks?
,
May 3 2017
,
May 9 2017
Ping. We are trying to clean up our benchmarks this quarter.
,
May 11 2017
,
May 11 2017
Ping again. Our team are trying to clean up the benchmarks space this quarter. If we don't here from you, we will remove blink_style.* benchmarks by next week.
,
May 12 2017
Sorry for the delay. I'm not sure what you mean by supported harnesses, or what it means for a test to live in the contrib/ directory? I suppose it's OK to remove, as it will need to be reworked once CSS's lazy parsing is enabled. The benchmark shouldn't be something anyone relies on but we do check in on it from time to time on chromeperf. Do you have suggestions for how this benchmark should be written?
,
May 12 2017
My suggestion for writing the benchmark is using blink_perf harness with tracing support. Tracing blink_perf design doc: https://docs.google.com/document/d/1feawFQpadFCcXEsVqz9z7ucSBIQBgFc23z873g69rKc/edit Example tests already written this way: https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/TestData/ For example, you can run: ./tools/perf/run_benchmark blink_perf --test-path=TestData/simple-blob-measure-async.html *I will write a more detailed README.md about how to use that soon. Please feel free to reach out to me if you have more questions.
,
May 12 2017
A test live in contrib/ directory mean you can still run the test locally, or on trybot but it won't be scheduled on the perf waterfall. You also need to main the benchmarks your self (see https://cs.chromium.org/chromium/src/tools/perf/contrib/README.md) For information about the harnesses in general, you can see this doc: go/new-benchmark-policy
,
May 15 2017
Thanks, feel free to remove the blink_style benchmark for now.
,
May 15 2017
,
May 15 2017
Thanks!
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c29a6a7213865882e149b20c4c8567df1f1f9360 commit c29a6a7213865882e149b20c4c8567df1f1f9360 Author: nednguyen <nednguyen@google.com> Date: Mon May 15 23:37:36 2017 Remove blink_style benchmarks BUG= 717214 Review-Url: https://codereview.chromium.org/2885563002 Cr-Commit-Position: refs/heads/master@{#471945} [modify] https://crrev.com/c29a6a7213865882e149b20c4c8567df1f1f9360/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/c29a6a7213865882e149b20c4c8567df1f1f9360/testing/buildbot/chromium.perf.json [modify] https://crrev.com/c29a6a7213865882e149b20c4c8567df1f1f9360/tools/perf/benchmark.csv [delete] https://crrev.com/bf4fc3116e4ddc3bc718b95c571a87c143211f0a/tools/perf/benchmarks/blink_style.py [delete] https://crrev.com/bf4fc3116e4ddc3bc718b95c571a87c143211f0a/tools/perf/measurements/blink_style.py [delete] https://crrev.com/bf4fc3116e4ddc3bc718b95c571a87c143211f0a/tools/perf/measurements/blink_style_unittest.py [modify] https://crrev.com/c29a6a7213865882e149b20c4c8567df1f1f9360/tools/perf/unowned_benchmarks.txt
,
May 15 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nedngu...@google.com
, May 1 2017