New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717214 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 575762



Sign in to add a comment

Remove blink_style.* benchmark or move it to tools/perf/contrib/ directory

Project Member Reported by nedngu...@google.com, May 1 2017

Issue description

These benchmarks doesn't use any of our supported harnesses, hence should be moved to  tools/perf/contrib/ directory or be removed.

dstockwell@ was the last one who touches this. Do you still need these benchmarks?
 
Components: Speed>Benchmarks
Status: Assigned (was: Untriaged)
Labels: -Pri-3 Pri-1
Ping. We are trying to clean up our benchmarks this quarter.
Blocking: 575762
Cc: mikelawther@chromium.org
Ping again. Our team are trying to clean up the benchmarks space this quarter. If we don't here from you, we will remove blink_style.* benchmarks by next week. 
Cc: -mikelawther@chromium.org meade@chromium.org dstockwell@google.com csharrison@chromium.org
Owner: ----
Status: Available (was: Assigned)
Sorry for the delay. I'm not sure what you mean by supported harnesses, or what it means for a test to live in the contrib/ directory?

I suppose it's OK to remove, as it will need to be reworked once CSS's lazy parsing is enabled. The benchmark shouldn't be something anyone relies on but we do check in on it from time to time on chromeperf. Do you have suggestions for how this benchmark should be written?
My suggestion for writing the benchmark is using blink_perf harness with tracing support.

Tracing blink_perf design doc: https://docs.google.com/document/d/1feawFQpadFCcXEsVqz9z7ucSBIQBgFc23z873g69rKc/edit

Example tests already written this way:
https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/TestData/

For example, you can run:
./tools/perf/run_benchmark blink_perf --test-path=TestData/simple-blob-measure-async.html

*I will write a more detailed README.md about how to use that soon. Please feel free to reach out to me if you have more questions.
A test live in contrib/ directory mean you can still run the test locally, or on trybot but it won't be scheduled on the perf waterfall. You also need to main the benchmarks your self (see https://cs.chromium.org/chromium/src/tools/perf/contrib/README.md)

For information about the harnesses in general, you can see this doc: go/new-benchmark-policy
Thanks, feel free to remove the blink_style benchmark for now.
Cc: nainar@chromium.org
Owner: nedngu...@google.com
Status: Started (was: Available)
Thanks!
Status: Fixed (was: Started)

Sign in to add a comment