New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717193 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Kevin: stylus via Pointer Events doesn't get to 1.0

Project Member Reported by adlr@chromium.org, May 1 2017

Issue description

On Kevin, using Pointer Events on Web to listen to stylus pressure, 1.0 value isn't possible, even if pressing very hard.

We may need to tweak the curve or cheat so that 1.0 is achievable.

Sean, can you look into this?
 
I checked the values reported by the kernel driver. A pressure value of around 1740 seems to be the maximum I can achieve. 

The maximum value is reported as 2047, which results in ~0.8 as a maximum normalized pressure. 

Andrew, should we add per-device calibration values as we do for touchpad pressure? 


Comment 2 by adlr@chromium.org, May 1 2017

Hm, so I think we want consistency in terms of knowing the true pressure from the user.

So, range + scale should give us that from the kernel. In this case, range should stop at 1740 (or thereabouts) and scale should allow us to translate to real units. I would like to see Wacom fix the range issue.

In that case, let me see if we have a good way to get Wacom to fix here.
Cc: tbuck...@chromium.org
Labels: Hotlist-Bradbury
Components: IO>Stylus
Cc: seobrien@chromium.org
Labels: -Pri-2 Pri-1
Owner: adlr@chromium.org
@adlr what's the status of a fix from Wacom? Is there a short-term solution we can use so Ink doesn't have to special-case Chrome OS?
Cc: mrcasey@google.com
Labels: M-61

Comment 7 by jkwang@google.com, Jun 13 2017

Cc: jkwang@chromium.org
Looks like this is more common than I thought, the pointer event from touch screen does not get to 1.0 either.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/c78a46378ec2e24fdfb861b09746f00742778754

commit c78a46378ec2e24fdfb861b09746f00742778754
Author: Jingkui Wang <jkwang@google.com>
Date: Thu Jun 22 01:48:01 2017

Add touch_firmware_calibration user & group

This CL add touch_firmware_calibration user & group to run
override_max_pressure.

BUG=chromium:717193
TEST=build image and test
CQ-DEPEND=CL:542475

Change-Id: I3f51230e2daac7bd77c4b96780268944b10c7a23
Reviewed-on: https://chromium-review.googlesource.com/542495
Commit-Ready: Jingkui Wang <jkwang@google.com>
Tested-by: Jingkui Wang <jkwang@google.com>
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>

[add] https://crrev.com/c78a46378ec2e24fdfb861b09746f00742778754/profiles/base/accounts/user/touch_firmware_calibration
[add] https://crrev.com/c78a46378ec2e24fdfb861b09746f00742778754/profiles/base/accounts/group/touch_firmware_calibration

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8763b0d2616003ef877a2a4666dc9636a0dfe436

commit 8763b0d2616003ef877a2a4666dc9636a0dfe436
Author: Jingkui Wang <jkwang@google.com>
Date: Thu Jun 22 01:48:01 2017

Add touch_firmware_calibration user/group to AccountsBaseline

touch_firmware_calibration is new user for running override_max_pressure
on devices that need to override evdev absinfo. This CL adds the user
and group to the test.

BUG=chromium:717193
TEST=test_that -b pbody ${DUT_IP} security_AccountsBaseline
CQ-DEPEND=CL:542495

Change-Id: I947a743a67ac26c9b8d792041606513089183b07
Reviewed-on: https://chromium-review.googlesource.com/542475
Commit-Ready: Jingkui Wang <jkwang@google.com>
Tested-by: Jingkui Wang <jkwang@google.com>
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>

[modify] https://crrev.com/8763b0d2616003ef877a2a4666dc9636a0dfe436/client/site_tests/security_AccountsBaseline/baseline.group
[modify] https://crrev.com/8763b0d2616003ef877a2a4666dc9636a0dfe436/client/site_tests/security_AccountsBaseline/baseline.passwd

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fc173408df71c87569846b90f25ab22865c7e67e

commit fc173408df71c87569846b90f25ab22865c7e67e
Author: Jingkui Wang <jkwang@google.com>
Date: Tue Jun 27 11:19:42 2017

touch_firmware_calibration: Add executable override_max_pressure

This patch adds override_max_pressure, which is an executable to override
the max pressure of the target device.

TEST=Build/flash image. Test on device.
BUG=chromium:717193

Change-Id: I939494dfd1fc8371fedcb3cab8fc899f46e6daa2
Reviewed-on: https://chromium-review.googlesource.com/540161
Commit-Ready: Jingkui Wang <jkwang@google.com>
Tested-by: Jingkui Wang <jkwang@google.com>
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/fc173408df71c87569846b90f25ab22865c7e67e/touch_firmware_calibration/README.md
[add] https://crrev.com/fc173408df71c87569846b90f25ab22865c7e67e/touch_firmware_calibration/touch_firmware_calibration.gyp
[add] https://crrev.com/fc173408df71c87569846b90f25ab22865c7e67e/touch_firmware_calibration/seccomp/override-max-pressure-seccomp-arm.policy
[add] https://crrev.com/fc173408df71c87569846b90f25ab22865c7e67e/touch_firmware_calibration/override_max_pressure.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/743ccbf9e927af3c01c3d405533b6d52c9f4b926

commit 743ccbf9e927af3c01c3d405533b6d52c9f4b926
Author: Jingkui Wang <jkwang@google.com>
Date: Tue Jun 27 20:49:31 2017

Add ebuild for touch_firmware_calibration

This patch adds ebuild of touch_firmware_calibration. It will compile
override_max_pressure and install it to /lib/udev.

TEST=Build/flash image. Test on device.
BUG=chromium:717193
CQ-DEPEND=CL:540161

Change-Id: I84034376851d10a9894e2da6ae164576cb283caa
Reviewed-on: https://chromium-review.googlesource.com/540071
Commit-Ready: Jingkui Wang <jkwang@google.com>
Tested-by: Jingkui Wang <jkwang@google.com>
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/743ccbf9e927af3c01c3d405533b6d52c9f4b926/chromeos-base/touch_firmware_calibration/touch_firmware_calibration-9999.ebuild

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 27 2017

Sign in to add a comment