New issue
Advanced search Search tips

Issue 717167 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

148.4% regression in rasterize_and_record_micro.top_25 at 467945:468051

Project Member Reported by nzolghadr@chromium.org, May 1 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=717167

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgsp6z6AkM


Bot(s) for this bug's original alert(s):

linux-release
Cc: vmp...@chromium.org
Owner: vmp...@chromium.org

=== Auto-CCing suspected CL author vmpstr@chromium.org ===

Hi vmpstr@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : vmpstr
  Commit : 78a9fddbe9db7c851cfefac5fd107aa11fcfc3ed
  Date   : Fri Apr 28 17:24:52 2017
  Subject: cc: Update rasterize and record to capture more work in recording.

Bisect Details
  Configuration: linux_perf_bisect
  Benchmark    : rasterize_and_record_micro.top_25
  Metric       : record_time/record_time
  Change       : 151.27% | 0.0334166666667 -> 0.0839652777778

Revision             Result                        N
chromium@467944      0.0334167 +- 0.00025          6      good
chromium@467998      0.0333958 +- 9.7717e-05       6      good
chromium@468025      0.0332708 +- 0.000268419      6      good
chromium@468038      0.0335 +- 0.000235702         6      good
chromium@468040      0.0333333 +- 0.000212459      6      good
chromium@468041      0.0840139 +- 0.000356812      6      bad       <--
chromium@468042      0.0842431 +- 0.00113103       6      bad
chromium@468045      0.0842986 +- 0.000766976      6      bad
chromium@468051      0.0839653 +- 0.000355594      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests rasterize_and_record_micro.top_25

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980773850368319344

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5242667773984768


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.

Comment 5 by vmi...@chromium.org, Aug 27 2017

Status: WontFix (was: Assigned)
From the description of the patch in #3, this was an expected measurement change.

Sign in to add a comment