Issue metadata
Sign in to add a comment
|
1.1% regression in system_health.memory_mobile at 467997:468065 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 1 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8980774305812960624
,
May 2 2017
=== BISECT JOB RESULTS === Bisect failed for unknown reasons Please contact the team (see below) and report the error. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_tools/load_tools_docs Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.docs system_health.memory_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8980774305812960624 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6288373527871488 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 2 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8980742225411145616
,
May 2 2017
=== Auto-CCing suspected CL author bmeurer@chromium.org === Hi bmeurer@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Benedikt Meurer Commit : 1320666798d52e590d8dfa9b0841504ef056dcbb Date : Fri Apr 28 08:05:15 2017 Subject: [cleanup] Handle JSFunction::prototype and string length in CallGetterIfAccessor. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_tools/load_tools_docs Change : 0.67% | 2581552.0 -> 2598826.66667 Revision Result N chromium@467996 2581552 +- 159.499 6 good chromium@468031 2581502 +- 115.62 6 good chromium@468034 2581567 +- 172.573 6 good chromium@468035 2581535 +- 223.028 6 good chromium@468035,v8@32124f3b13 2581534 +- 115.62 6 good chromium@468035,v8@1320666798 2598861 +- 136.078 6 bad <-- chromium@468035,v8@81253a5296 2598847 +- 175.058 6 bad chromium@468035,v8@1a8e7d13a1 2598812 +- 127.373 6 bad chromium@468035,v8@3b46a9842b 2598864 +- 0.0 6 bad chromium@468036 2598881 +- 94.9386 6 bad chromium@468040 2598844 +- 164.244 6 bad chromium@468048 2598827 +- 178.408 6 bad chromium@468065 2598827 +- 178.408 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.docs system_health.memory_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8980742225411145616 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6288373527871488 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 2 2017
ishell@, jkummerow@ any idea how this can lead to an increase in memory consumption? Doesn't sound reasonable to me.
,
May 5 2017
Agreed, it seems very surprising that that CL could increase memory usage. Maybe it just shifts GC timing?
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Sep 14 2017
WontFix-ing because the bisect only detected a 17kib regression, below our current thresholds. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by nzolghadr@chromium.org
, May 1 2017