New issue
Advanced search Search tips

Issue 717138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Promote Some Functions to bind.h

Project Member Reported by robliao@chromium.org, May 1 2017

Issue description

Discussion from https://codereview.chromium.org/2423423002/

A quick pass...
Promoted to bind.h
* Unretained
* RetainedRef
* ConstRef
* Owned
* Passed
* IgnoreResult

bind_internals
* Unwrap

bind_helpers
* DoNothing
* DeletePointer

Note: When updating this list, edit the description directly instead of indicating changes in the comments section below (makes reading the bug easier).
 
Cc: pkasting@chromium.org
Adding pkasting@ who's doing some magical stuff with DoNothing.
Owner: pkasting@chromium.org
Status: Started (was: Available)
Yeah, I basically have to do this work due to the DoNothing refactor.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/383640f577e65830b7c3cb3c5e2f362badc8e913

commit 383640f577e65830b7c3cb3c5e2f362badc8e913
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Feb 13 06:22:40 2018

Add missing #includes (IWYU).

These were exposed by work to refactor base/bind.h.

BUG= 717138 
TEST=none
TBR=jochen,rockot,reveman,tzik,rohitrao,jorgelo,satorux,lcwu,gab,mef,irisu,liberato,nicholss

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I901f3d4f9f1791744ce94340df7c2e7389f88a0b
Reviewed-on: https://chromium-review.googlesource.com/914967
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536268}
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/message_loop/message_pump_perftest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/pending_task_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/task/cancelable_task_tracker.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/task_scheduler/task_tracker_posix_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/task_scheduler/task_tracker_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/task_scheduler/task_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/test/scoped_task_environment_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/base/win/wait_chain_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chrome/browser/media/router/mojo/media_router_mojo_metrics_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chrome/browser/net/dns_probe_runner.h
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chrome/browser/ui/profile_error_dialog.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chrome/browser/vr/databinding/binding_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chrome/browser/vr/databinding/vector_binding_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chrome/test/chromedriver/chrome/chrome_finder_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chrome/utility/importer/bookmarks_file_importer.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromecast/browser/cast_net_log.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/components/tether/fake_asynchronous_shutdown_object_container.h
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/components/tether/fake_synchronous_shutdown_object_container.h
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/dbus/fake_shill_device_client.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/dbus/shill_service_client.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/dbus/shill_third_party_vpn_driver_client.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/disks/disk_mount_manager.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/client_cert_resolver.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/network_cert_migrator.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/network_configuration_handler.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/network_configuration_handler_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/network_connect.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/network_device_handler_impl.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/policy_applicator.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/shill_property_handler.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/chromeos/network/shill_property_handler_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/cryptauth/device_to_device_secure_context_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/cryptauth/fake_secure_message_delegate_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/favicon/core/favicon_handler_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/invalidation/impl/gcm_invalidation_bridge_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/leveldb_proto/proto_database_impl_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/payments/content/android/payment_manifest_parser_android.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/proximity_auth/bluetooth_connection.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/storage_monitor/media_storage_util_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/sync/driver/fake_sync_client.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/sync/driver/model_type_controller_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/sync/syncable/directory_backing_store_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/components/sync_sessions/session_data_type_controller_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/content/public/test/fake_download_item.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/content/renderer/renderer_main_platform_delegate_mac.mm
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/content/shell/browser/shell_net_log.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/dbus/bus_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/dbus/end_to_end_async_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/base/device_monitor_win.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/bluetooth/bluetooth_discovery_session.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/bluetooth/bluez/bluetooth_adapter_profile_bluez_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/bluetooth/bluez/bluetooth_device_bluez.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/bluetooth/bluez/bluetooth_socket_bluez_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/bluetooth/test/bluetooth_test_bluez.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/device/geolocation/wifi_data_provider_common_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/extensions/renderer/id_generator_custom_bindings.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/gpu/ipc/client/gpu_memory_buffer_impl_android_hardware_buffer.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/gpu/ipc/client/gpu_memory_buffer_impl_dxgi.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/headless/lib/browser/headless_net_log.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/headless/public/util/compositor_controller_browsertest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/ios/chrome/browser/ui/content_suggestions/mediator_util.mm
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/media/gpu/vaapi/vaapi_wrapper.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/media/renderers/renderer_impl_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/mojo/common/data_pipe_utils.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/mojo/public/cpp/bindings/callback_helpers.h
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/mojo/public/cpp/bindings/tests/callback_helpers_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/base/address_list.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/base/address_tracker_linux.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/base/address_tracker_linux_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/ftp/ftp_ctrl_response_buffer.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/log/net_log.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/log/net_log_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/log/net_log_with_source.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/nqe/event_creator.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/quic/core/quic_connection_test.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/quic/core/quic_session_test.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/quic/core/quic_stream_sequencer_test.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/quic/core/quic_stream_test.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/socket/socket_net_log_params.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/spdy/chromium/header_coalescer.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/spdy/chromium/spdy_buffer_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/spdy/chromium/spdy_read_queue_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/ssl/openssl_ssl_util.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/test/scoped_disable_exit_on_dfatal.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/net/tools/quic/quic_dispatcher_test.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/client/chromoting_client_runtime.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/host/chromoting_host_context.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/protocol/audio_decode_scheduler_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/protocol/audio_reader.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/protocol/client_video_dispatcher.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/protocol/pairing_authenticator_base.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/protocol/port_allocator.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/protocol/spake2_authenticator_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/remoting/protocol/v2_authenticator_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/sandbox/linux/integration_tests/seccomp_broker_process_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/sandbox/linux/syscall_broker/broker_process_unittest.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/storage/browser/fileapi/quota/quota_reservation.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/storage/browser/fileapi/quota/quota_reservation_buffer.cc
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/third_party/WebKit/Source/platform/ContentSettingCallbacks.h
[modify] https://crrev.com/383640f577e65830b7c3cb3c5e2f362badc8e913/third_party/WebKit/Source/platform/wtf/Functional.h

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a85265e3f9b269648fab357695479fd56fcd1e2d

commit a85265e3f9b269648fab357695479fd56fcd1e2d
Author: Peter Kasting <pkasting@chromium.org>
Date: Thu Feb 15 08:30:23 2018

Reorganize functions in base/bind*.h.

The ownership wrappers (Owned, Passed, etc.) move from bind_helpers.h to bind.h.
Most other content of bind_helpers.h was really only necessary to implement the
code in bind_internals.h, and moves there.

BUG= 717138 
TEST=none
TBR=jri

Change-Id: Ib6d468e58930529dbee587d331b177b93da2f13a
Reviewed-on: https://chromium-review.googlesource.com/915282
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Jana Iyengar <jri@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536968}
[modify] https://crrev.com/a85265e3f9b269648fab357695479fd56fcd1e2d/base/BUILD.gn
[modify] https://crrev.com/a85265e3f9b269648fab357695479fd56fcd1e2d/base/bind.h
[modify] https://crrev.com/a85265e3f9b269648fab357695479fd56fcd1e2d/base/bind_helpers.h
[delete] https://crrev.com/260f8dfb276481e7ee42565e90e3155a126ae0aa/base/bind_helpers_unittest.cc
[modify] https://crrev.com/a85265e3f9b269648fab357695479fd56fcd1e2d/base/bind_internal.h
[modify] https://crrev.com/a85265e3f9b269648fab357695479fd56fcd1e2d/base/bind_unittest.cc
[modify] https://crrev.com/a85265e3f9b269648fab357695479fd56fcd1e2d/net/quic/core/quic_crypto_stream_test.cc
[modify] https://crrev.com/a85265e3f9b269648fab357695479fd56fcd1e2d/net/quic/core/quic_sent_packet_manager_test.cc

Status: Fixed (was: Started)

Sign in to add a comment