New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717107 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.9% regression in system_health.memory_mobile at 468222:468234

Project Member Reported by nzolghadr@chromium.org, May 1 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=717107

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg8tLjqQoM


Bot(s) for this bug's original alert(s):

android-one
Cc: avayvod@chromium.org
Owner: avayvod@chromium.org

=== Auto-CCing suspected CL author avayvod@chromium.org ===

Hi avayvod@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : avayvod
  Commit : 77db41b769602da7ccc0106c285490f149fe343d
  Date   : Sat Apr 29 04:09:14 2017
  Subject: Remove the explicit dependency between HTMLMediaElement and MediaControls

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/browse_news/browse_news_qq
  Change       : 4.02% | 14821485.3333 -> 15417785.3333

Revision             Result                  N
chromium@468221      14821485 +- 216330      6      good
chromium@468222      14873771 +- 147056      6      good
chromium@468223      15370491 +- 161317      6      bad       <--
chromium@468225      15427561 +- 156671      6      bad
chromium@468228      15424145 +- 165748      6      bad
chromium@468234      15417785 +- 114070      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.qq system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980776880790868800

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4808798499241984


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 717125  has been merged into this issue.
 Issue 717105  has been merged into this issue.
 Issue 717109  has been merged into this issue.
 Issue 717111  has been merged into this issue.
 Issue 717110  has been merged into this issue.
 Issue 717139  has been merged into this issue.
 Issue 717112  has been merged into this issue.
 Issue 717144  has been merged into this issue.
 Issue 717145  has been merged into this issue.
Issue 717032 has been merged into this issue.
Issue 717036 has been merged into this issue.
Issue 717038 has been merged into this issue.
Issue 717027 has been merged into this issue.
Status: Fixed (was: Untriaged)
Seems like the memory went back down to normal levels?
The culprit CL introduced a memory leak fixed here: https://codereview.chromium.org/2848363002/ (r468525)

Sign in to add a comment