Issue metadata
Sign in to add a comment
|
webkit_tests failing on chromium.webkit/WebKit Linux Trusty Leak |
||||||||||||||||||||||
Issue descriptionwebkit_tests failing on chromium.webkit/WebKit Linux Trusty Leak Builders failed on: - WebKit Linux Trusty Leak: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Starting with build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4343 Hundreds of tests are failing with leaks: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Linux_Trusty_Leak%2F4343%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout 22:45:40.286 5970 [736/737] media/media-fragments/TC0015.html failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,145],"numberOfLiveResources":[0,2],"numberOfLiveSuspendableObjects":[2,4]})) There are only two commits in the blame list: https://chromium.googlesource.com/chromium/src/+/77db41b769602da7ccc0106c285490f149fe343d Remove the explicit dependency between HTMLMediaElement and MediaControls wrt the cast buttons. https://chromium.googlesource.com/chromium/src/+/232757946494489747c5752e32890f3819f2a658 Added feature flag for new remote playback pipeline both by avayvod@chromium.org Anton: if you can't find a quick fix can you please revert your changes as you investigate? Thanks.
,
May 1 2017
https://codereview.chromium.org/2848363002 should fix it.
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27e76cce52a397ea93c9bcf38454c2b4013b7db9 commit 27e76cce52a397ea93c9bcf38454c2b4013b7db9 Author: avayvod <avayvod@chromium.org> Date: Tue May 02 01:23:30 2017 [Media, Controls] Use a weak ref to the listener from callback. Seems like holding a strong reference causes the leakage. BUG= 717094 TEST=run the failing tests locally with --enable-leak-detection TBR=haraken NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2848363002 Cr-Commit-Position: refs/heads/master@{#468525} [modify] https://crrev.com/27e76cce52a397ea93c9bcf38454c2b4013b7db9/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp
,
May 2 2017
Should be fixed now. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by avayvod@chromium.org
, May 1 2017