IndexedDB layout tests failing with --site-per-process |
||||||
Issue descriptionAfter binji@'s r468084 landed, the Site Isolation Win FYI bot started consistently failing the following layout tests: virtual/sharedarraybuffer/storage/indexeddb/blob-valid-after-deletion.html virtual/sharedarraybuffer/storage/indexeddb/blob-valid-before-commit.html virtual/sharedarraybuffer/storage/indexeddb/empty-crash.html https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/18939 https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/18964 Test output for blob-valid-after-deletion.html: +FAIL document.getElementById('frame0').contentDocument.body.innerText should be Blob A content. Threw exception TypeError: Cannot read property 'body' of null +FAIL document.getElementById('frame1').contentDocument.body.innerText should be Blob A content. Threw exception TypeError: Cannot read property 'body' of null +FAIL document.getElementById('frame2').contentDocument.body.innerText should be Blob B content. Threw exception TypeError: Cannot read property 'body' of null blob-valid-before-commit.html looks similar. The empty-crash.html test times out. You can run locally with: ./Tools/Scripts/run-webkit-tests -v -t Default --additional-drt-flag=--site-per-process --no-retry-failures virtual/sharedarraybuffer/storage/indexeddb/blob-valid-after-deletion.html I'll disable these on the bot for now, but binji@, can you take a look soon? This mode enables out-of-process iframes for cross-site iframes. This could represent a bug or regression for extensions, which currently use out-of-process iframes for web iframes. Thanks!
,
May 1 2017
Yeah, those three are listed in FlagExpectations/site-per-process We should add the virtual copies to that file, fix will be the same.
,
May 1 2017
As an aside, it looks like we could rework all of those tests using FileReader instead of iframes. But presumably we want to fix the site isolation issue (issue 651534 maybe?)
,
May 1 2017
Ah, so they are! They're in the untriaged section at the bottom without a bug, so we can use this bug to track them. I have a CL about to land that will disable them in https://codereview.chromium.org/2852923003/. jsbell@ / binji@: Feel free to adjust owner, since you have more context. Thanks!
,
May 1 2017
Comment 3: I see. I'll ask Nick about it when I see him, but I'll tentatively mark that as blocking this issue.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/978ff041e16a75594225bb33bfd470f92c170314 commit 978ff041e16a75594225bb33bfd470f92c170314 Author: creis <creis@chromium.org> Date: Mon May 01 18:58:26 2017 Disable failing sharedarraybuffer tests on Site Isolation FYI bots. BUG= 717092 TEST=Bot goes green. Review-Url: https://codereview.chromium.org/2852923003 Cr-Commit-Position: refs/heads/master@{#468377} [modify] https://crrev.com/978ff041e16a75594225bb33bfd470f92c170314/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
May 1 2017
Assigning to me for tracking. As noted, we probably want to fix this (via the blocking issue) but once we have dedicated tests for that we could rework these particular tests to avoid iframes entirely.
,
May 10 2017
Bumping down Pri - test-specific and caused by a site isolation issue.
,
May 15 2018
This might be fixed now
,
Jun 28 2018
Looks like this was fixed by https://chromium-review.googlesource.com/953129 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jsb...@chromium.org
, May 1 2017