New issue
Advanced search Search tips

Issue 717090 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

biod should use strerror() to report errors

Project Member Reported by norvez@chromium.org, May 1 2017

Issue description


I'm debugging an issue with authentication where the libfp function returns a failure, and the log message is:

Unexpected result from matching templates: -22

It's coming from here:
https://chromium.googlesource.com/chromiumos/platform2/+/master/biod/fpc_biometrics_manager.cc#643

It would be nice if instead of simply logging the error code (-EINVAL in this case) the log would show the associated error string, it makes it easier to figure out what's wrong.
 

Comment 1 by mqg@google.com, May 1 2017

Cc: za...@chromium.org
+zachr,

You are the expert on this one. 

Comment 2 by za...@chromium.org, May 1 2017

strerror is tricky because it lacks thread-safety (and we have multiple threads generating errno's) and there are two versions of strerror_r to choose from. I'm not opposed to the change though if done properly.
Components: OS>Kernel

Comment 4 by mqg@chromium.org, Jan 12 2018

Status: WontFix (was: Unconfirmed)
Marking obsolete because the new program is implemented with a different version of software.


Sign in to add a comment