vr_shell_unittests failing on BinaryGltfParserTest.ParseBinary |
||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromium.android/builders/KitKat%20Tablet%20Tester First failure: https://uberchromegw.corp.google.com/i/chromium.android/builders/KitKat%20Tablet%20Tester/builds/7450 I 50.560s run_tests_on_device(057ccb85) [ RUN ] BinaryGltfParserTest.ParseBinary I 50.560s run_tests_on_device(057ccb85) [ERROR:gltf_parser.cc(406)] Failed to read binary glTF: Content not a valid JSON I 50.560s run_tests_on_device(057ccb85) ../../chrome/browser/android/vr_shell/gltf_parser_unittest.cc:178: Failure I 50.560s run_tests_on_device(057ccb85) Value of: asset I 50.560s run_tests_on_device(057ccb85) Actual: false I 50.560s run_tests_on_device(057ccb85) Expected: true I 50.561s run_tests_on_device(057ccb85) ../../chrome/browser/android/vr_shell/gltf_parser_unittest.cc:179: Failure I 50.561s run_tests_on_device(057ccb85) Value of: buffers.size() I 50.561s run_tests_on_device(057ccb85) Actual: 0 I 50.561s run_tests_on_device(057ccb85) Expected: 1u I 50.561s run_tests_on_device(057ccb85) Which is: 1 I 50.561s run_tests_on_device(057ccb85) [ CRASHED ]
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f02534fb0fb3a45f76c16d06da2b46c0625a668 commit 1f02534fb0fb3a45f76c16d06da2b46c0625a668 Author: aelias <aelias@chromium.org> Date: Mon May 01 17:14:48 2017 Revert of Implementing Binary glTF reader for the VR controller model (patchset #3 id:40001 of https://codereview.chromium.org/2852533004/ ) Reason for revert: Test added in this patch fails on downstream bot (see http://crbug.com/717088 ) BUG= 717088 Original issue's description: > Implementing Binary glTF reader for the VR controller model > > The binary glTF format enables us to deliver 3D models on a single file with minimal size. > > Binary glTF Specification in: https://github.com/KhronosGroup/glTF/tree/master/extensions/Khronos/KHR_binary_glTF > > BUG=644562 > > Review-Url: https://codereview.chromium.org/2852533004 > Cr-Commit-Position: refs/heads/master@{#468198} > Committed: https://chromium.googlesource.com/chromium/src/+/b416391e0ae62217afb7ea5ffeb04ab2640a96ed TBR=mthiesse@chromium.org,bajones@chromium.org,acondor@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644562 Review-Url: https://codereview.chromium.org/2852103002 Cr-Commit-Position: refs/heads/master@{#468338} [modify] https://crrev.com/1f02534fb0fb3a45f76c16d06da2b46c0625a668/chrome/browser/android/vr_shell/BUILD.gn [modify] https://crrev.com/1f02534fb0fb3a45f76c16d06da2b46c0625a668/chrome/browser/android/vr_shell/gltf_parser.cc [modify] https://crrev.com/1f02534fb0fb3a45f76c16d06da2b46c0625a668/chrome/browser/android/vr_shell/gltf_parser.h [modify] https://crrev.com/1f02534fb0fb3a45f76c16d06da2b46c0625a668/chrome/browser/android/vr_shell/gltf_parser_unittest.cc [delete] https://crrev.com/0f27852ca4088b309083e746c3eaab29fb0b4415/chrome/browser/android/vr_shell/test/data/sample.glb [modify] https://crrev.com/1f02534fb0fb3a45f76c16d06da2b46c0625a668/chrome/browser/android/vr_shell/vr_controller_model.cc
,
May 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by aelias@chromium.org
, May 1 2017