New issue
Advanced search Search tips

Issue 717085 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Oct 2017
Cc:
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: [lighthouse] Deprecate Audits 1.0 panel

Project Member Reported by paulir...@chromium.org, May 1 2017 
1. Current "Audits" panel moves to "Legacy Audits". Available via to "More Tools"
2. Communicate `devtools.audits` API deprecation. (Consumers can contribute to Lighthouse.)
Screen Shot 2017-05-01 at 10.00.31 AM.png
59.8 KB View Download

Comment 1 by dgozman@chromium.org, May 4 2017 

Screenshot with new panels.
audits.png
51.0 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53247a6fbf1240613a9a79be36b6a3650fd19ec

commit f53247a6fbf1240613a9a79be36b6a3650fd19ec
Author: dgozman <dgozman@chromium.org>
Date: Tue May 16 19:37:12 2017

[DevTools] Enable audits2 by default

BUG= 717085 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2884133002
Cr-Commit-Position: refs/heads/master@{#472187}

[modify] https://crrev.com/f53247a6fbf1240613a9a79be36b6a3650fd19ec/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64d8ca3ed8b04b73f40ed23d1595826975970c54

commit 64d8ca3ed8b04b73f40ed23d1595826975970c54
Author: Will Chen <chenwilliam@chromium.org>
Date: Mon Oct 02 20:36:29 2017

DevTools: take audits 2.0 out of experiments

Audits 2.0 has been a default experiment for a while, and should be
permanent now so this is just some clean-up.

Drive-by: remove dead code for coverage tests in Main.js.

Bug:  717085 
Change-Id: I71a30da1616b8f6b9d76341e122d62b42cda1cce
Reviewed-on: https://chromium-review.googlesource.com/692987
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505763}
[modify] https://crrev.com/64d8ca3ed8b04b73f40ed23d1595826975970c54/third_party/WebKit/Source/devtools/front_end/audits/module.json
[modify] https://crrev.com/64d8ca3ed8b04b73f40ed23d1595826975970c54/third_party/WebKit/Source/devtools/front_end/audits2/module.json
[modify] https://crrev.com/64d8ca3ed8b04b73f40ed23d1595826975970c54/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2214bd4a3a01c5830d7a26afb4fe20c2dd9ca134

commit 2214bd4a3a01c5830d7a26afb4fe20c2dd9ca134
Author: Will Chen <chenwilliam@chromium.org>
Date: Mon Oct 02 23:05:47 2017

DevTools: make legacy audits remote

Because legacy audits is deprecated and has very low usage, 
we should make it a remote module to slim down Chrome's binary size.

Bug:  717085 
Change-Id: I9e79912853a1340f059b8787d53de36b3f2343ad
Reviewed-on: https://chromium-review.googlesource.com/692991
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505839}
[modify] https://crrev.com/2214bd4a3a01c5830d7a26afb4fe20c2dd9ca134/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/2214bd4a3a01c5830d7a26afb4fe20c2dd9ca134/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/2214bd4a3a01c5830d7a26afb4fe20c2dd9ca134/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json

Comment 7 by dgozman@chromium.org, Oct 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment