New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717080 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

blink_perf.canvas failing on mac air 10.11 and several windows platforms

Project Member Reported by rnep...@chromium.org, May 1 2017

Issue description

https://build.chromium.org/p/chromium.perf/builders/Mac%20Air%2010.11%20Perf?numbuilds=200


FATAL: Got an exception while running test.run with name=TypeError, message=experimental.createImageData is not a function
Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 88, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 302, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/tools/perf/benchmarks/blink_perf.py", line 218, in ValidateAndMeasurePage
    results.current_page, metric, units, values))
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/value/list_of_scalar_values.py", line 83, in __init__
    assert len(values) > 0
AssertionError
 
Summary: blink_perf.canvas failing on mac air 10.11 and several windows platforms (was: blink_perf.canvas failing on mac air 10.11)
Windows platforms:
Zenbook - 
https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf

win 10 high dpi -
https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf

win 7 ATI GPU -
https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf

Win 7 Nvidia GPU - 
https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf

=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : blink_perf.canvas
  Metric       : draw-static-canvas-2d-to-hw-accelerated-canvas-2d/draw-static-canvas-2d-to-hw-accelerated-canvas-2d.html


To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=draw.static.canvas.2d.to.hw.accelerated.canvas.2d.html blink_perf.canvas

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980780002156586416

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6028123943993344


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: zakerinasab@chromium.org
Owner: zakerinasab@chromium.org

=== Auto-CCing suspected CL author zakerinasab@chromium.org ===

Hi zakerinasab@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : zakerinasab
  Commit : 03d8a3084d1e21b685437607961f5ddccdf032b1
  Date   : Thu Apr 27 11:10:45 2017
  Subject: Fix BaseRenderingContext2D create/put/get-ImageData() for color managed canvas

Bisect Details
  Configuration: winx64nvidia_perf_bisect
  Benchmark    : blink_perf.canvas
  Metric       : draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d

Revision             Exit Code      N
chromium@467593      0 +- N/A       2      good
chromium@467615      0 +- N/A       2      good
chromium@467626      0 +- N/A       2      good
chromium@467632      0 +- N/A       2      good
chromium@467634      0 +- N/A       2      good
chromium@467635      1 +- N/A       2      bad       <--
chromium@467637      1 +- N/A       2      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.canvas

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980779701633103088

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4975869774266368


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: junov@chromium.org
Adding benchmark owner as this may be something wrong on the benchmark end based on the stack trace.
Project Member

Comment 7 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ac4eb510183e617a186af25a4a94afe11ace92

commit 89ac4eb510183e617a186af25a4a94afe11ace92
Author: zakerinasab <zakerinasab@chromium.org>
Date: Mon May 01 21:30:50 2017

Fix getImageDataColorManaged performance test

getImageDataColorManaged performance test must call createImageData from a context 2D.

BUG= 717080 

Review-Url: https://codereview.chromium.org/2855683002
Cr-Commit-Position: refs/heads/master@{#468416}

[modify] https://crrev.com/89ac4eb510183e617a186af25a4a94afe11ace92/third_party/WebKit/PerformanceTests/Canvas/getImageDataColorManaged.html

Status: Fixed (was: Untriaged)

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : blink_perf.canvas
  Metric       : draw-static-canvas-2d-to-hw-accelerated-canvas-2d/draw-static-canvas-2d-to-hw-accelerated-canvas-2d.html

Revision             Exit Code      N
chromium@467620      0 +- N/A       2      good
chromium@467689      0 +- N/A       2      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=draw.static.canvas.2d.to.hw.accelerated.canvas.2d.html blink_perf.canvas

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980742230716576832

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6028123943993344


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 11 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7ea169be1422d47ffb14c5ba443ee4fb986650f

commit c7ea169be1422d47ffb14c5ba443ee4fb986650f
Author: zakerinasab <zakerinasab@chromium.org>
Date: Tue May 02 16:13:14 2017

Remove getImageDataColorManaged performance test

getImageDataColorManaged performance test must call createImageData from a context 2D. This is behind a flag and the perf test continues to fail on perf bots. Removing the test for now.  crbug.com/717549  is filed for follow up.

BUG= 717080 

Review-Url: https://codereview.chromium.org/2855683002
Cr-Original-Commit-Position: refs/heads/master@{#468416}
Committed: https://chromium.googlesource.com/chromium/src/+/89ac4eb510183e617a186af25a4a94afe11ace92
Review-Url: https://codereview.chromium.org/2855683002
Cr-Commit-Position: refs/heads/master@{#468661}

[delete] https://crrev.com/376186504c93feac078435f1620005d15609974f/third_party/WebKit/PerformanceTests/Canvas/getImageDataColorManaged.html

Looks like the current run on this bot is green:
https://luci-milo.appspot.com/buildbot/chromium.perf/Mac%20Pro%2010.11%20Perf/

Sign in to add a comment