New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717078 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

v8.infinite_scroll-classic_tbmv2 and v8.infinite_scroll_tbmv2 failing on multiple platforms

Project Member Reported by rnep...@chromium.org, May 1 2017

Issue description

https://build.chromium.org/p/chromium.perf/builders/Mac%20Air%2010.11%20Perf/builds/775

https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Air_10.11_Perf%2F775%2F%2B%2Frecipes%2Fsteps%2Fv8.infinite_scroll-classic_tbmv2_on_Intel_GPU_on_Mac_on_Mac-10.11%2F0%2Fstdout


Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 88, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 300, in RunStory
    self._current_page.Run(self)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 112, in Run
    self.RunPageInteractions(action_runner)
  File "/b/s/w/ir/tools/perf/page_sets/infinite_scroll_cases.py", line 51, in RunPageInteractions
    self._Scroll(action_runner, self.SCROLL_DISTANCE, self.SCROLL_STEP)
  File "/b/s/w/ir/tools/perf/page_sets/infinite_scroll_cases.py", line 73, in _Scroll
    raise Exception('Scrolling stuck at %d' % remaining)
Exception: Scrolling stuck at 20157
 
Summary: v8.infinite_scroll-classic_tbmv2 and v8.infinite_scroll_tbmv2 failing on mac (was: v8.infinite_scroll-classic_tbmv2 failing on mac)

=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : v8.infinite_scroll-classic_tbmv2
  Metric       : interactive:500ms_window:renderer_eqt:v8:compile_max/flickr


To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=flickr v8.infinite_scroll-classic_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980780379696898192

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5773537006059520


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Summary: v8.infinite_scroll-classic_tbmv2 and v8.infinite_scroll_tbmv2 failing on mac and windows (was: v8.infinite_scroll-classic_tbmv2 and v8.infinite_scroll_tbmv2 failing on mac)
failing on windows as well.
Labels: OS-Android OS-Windows
Summary: v8.infinite_scroll-classic_tbmv2 and v8.infinite_scroll_tbmv2 failing on multiple platforms (was: v8.infinite_scroll-classic_tbmv2 and v8.infinite_scroll_tbmv2 failing on mac and windows)
Also on android.

=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : v8.infinite_scroll-classic_tbmv2
  Metric       : interactive:500ms_window:renderer_eqt:v8:compile_max/flickr


To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=flickr v8.infinite_scroll-classic_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980777473222607312

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5773537006059520


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : v8.infinite_scroll-classic_tbmv2
  Metric       : interactive:500ms_window:renderer_eqt:v8:gc_max/flickr

Revision             Exit Code      N
chromium@467636      1 +- N/A       2      good
chromium@467954      1 +- N/A       2      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=flickr v8.infinite_scroll-classic_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980778569497012912

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5810873425199104


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: altimin@chromium.org
Owner: altimin@chromium.org

=== Auto-CCing suspected CL author altimin@chromium.org ===

Hi altimin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : altimin
  Commit : c18764a33a595baab6ba35a1447e51c7c74b6e30
  Date   : Thu Apr 27 10:39:19 2017
  Subject: [scheduler] Move some task types to suspendable task runner.

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : v8.infinite_scroll-classic_tbmv2
  Metric       : interactive:500ms_window:renderer_eqt:v8:gc_max/flickr

Revision             Exit Code      N
chromium@467620      0 +- N/A       3      good
chromium@467631      0 +- N/A       3      good
chromium@467632      0 +- N/A       3      good
chromium@467633      1 +- N/A       3      bad       <--
chromium@467634      1 +- N/A       3      bad
chromium@467636      1 +- N/A       3      bad
chromium@467641      1 +- N/A       3      bad
chromium@467661      1 +- N/A       3      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=flickr v8.infinite_scroll-classic_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980778476049009792

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5892104275886080


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Ironically I am only doing this shift because Altimin@ is in London where it is a Holiday today. I'm going to revert this CL since its a holiday.
Cc: fdoray@chromium.org
Owner: fdoray@chromium.org

=== Auto-CCing suspected CL author fdoray@chromium.org ===

Hi fdoray@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : fdoray
  Commit : b4046080f31d65ed2618ecf1a2538ac322e9848a
  Date   : Thu Apr 27 10:21:08 2017
  Subject: Use TaskScheduler instead of blocking pool in external_metrics.cc.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : v8.infinite_scroll-classic_tbmv2
  Metric       : benchmark_duration/benchmark_duration

Revision             Exit Code      N
chromium@467615      0 +- N/A       2      good
chromium@467628      0 +- N/A       2      good
chromium@467630      0 +- N/A       2      good
chromium@467631      0 +- N/A       2      good
chromium@467632      1 +- N/A       2      bad       <--
chromium@467635      1 +- N/A       2      bad
chromium@467641      1 +- N/A       2      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.infinite_scroll-classic_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980776596810999664

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4521137159012352


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: -altimin@chromium.org -fdoray@chromium.org
Owner: altimin@chromium.org
altimin's change r467633 is more likely than my change r467632 to have caused this regression. Feel free to re-add me if you think I'm wrong.
https://build.chromium.org/p/chromium.perf/builders/Mac%20Air%2010.11%20Perf

It is no longer failing, so it was altimin's CL most likely.
Cc: martiniss@chromium.org nedngu...@google.com u...@chromium.org
 Issue 717372  has been merged into this issue.
THis is causing a 10+ minutes regression in perf waterfall cycle time. Can you please fix address this soon or revert your CL if possible.
I think you'll need to be a little clearer with that. Is altimin@'s original CL causing the time regression? Or is my revert of it causing it?
According to https://bugs.chromium.org/p/chromium/issues/detail?id=717372#c6, altimin@'s original CL caused the time regression
Ah. I already reverted that for causing he failures, so that should recover for now.
Should these bugs have auto-merged like that since one was a failure and one was a regression?
In this case, the regression is to the benchmark's cycle time, which probably was triggered by the TimedOut failure. So it's fine, I think.
Status: Fixed. (was: Untriaged)
Randy, thank you very much for handling this. Marking as fixed as it is reverted now.
Status: Fixed (was: Fixed.)
Cc: pmarko@chromium.org
 Issue 716641  has been merged into this issue.

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : altimin
  Commit : c18764a33a595baab6ba35a1447e51c7c74b6e30
  Date   : Thu Apr 27 10:39:19 2017
  Subject: [scheduler] Move some task types to suspendable task runner.

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : v8.infinite_scroll-classic_tbmv2
  Metric       : benchmark_duration/benchmark_duration
  Change       : 51.62% | 9.59153055416 -> 14.5428277777

Revision             Result                    N
chromium@467625      9.59153 +- 0.27201        6      good
chromium@467629      9.44338 +- 1.0055         6      good
chromium@467631      9.61481 +- 0.554949       6      good
chromium@467632      9.49117 +- 0.0999335      6      good
chromium@467633      14.8497 +- 6.72131        6      bad       <--
chromium@467641      14.417 +- 3.84528         6      bad
chromium@467657      15.4334 +- 3.8873         6      bad
chromium@467688      14.5428 +- 5.48703        6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.infinite_scroll-classic_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980685223147592384

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5773537006059520


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 29 by dtu@chromium.org, May 4 2017

Cc: dtu@chromium.org
 Issue 716435  has been merged into this issue.

Comment 30 by dtu@chromium.org, May 4 2017

 Issue 716430  has been merged into this issue.

Comment 31 by dtu@chromium.org, May 4 2017

Cc: hpayer@google.com
 Issue 716424  has been merged into this issue.

Comment 32 by dtu@chromium.org, May 4 2017

Cc: rmcilroy@chromium.org
 Issue 715991  has been merged into this issue.

Sign in to add a comment