Orderfile generation failing due to duplicate "isolatedProcess" |
||
Issue descriptionhttps://uberchromegw.corp.google.com/i/internal.client.clank/builders/orderfile-clankium?numbuilds=50 First failure https://uberchromegw.corp.google.com/i/internal.client.clank/builders/orderfile-clankium/builds/5061 Log message: INFO:root:Try printing formatted exception: <type 'exceptions.Exception'> Unexpected number of occurrences of android:isolatedProcess="true" in AndroidManifest.xml. Expected 1, found 2. <traceback object at 0x7f5bb414c290> Traceback (most recent call last): <module> at /b/build/slave/orderfile-clankium/build/src/clank/tools/orderfile_generator.py:801 sys.exit(main(sys.argv)) main at /b/build/slave/orderfile-clankium/build/src/clank/tools/orderfile_generator.py:787 success = orderfile_generator.Generate() Generate at /b/build/slave/orderfile-clankium/build/src/clank/tools/orderfile_generator.py:690 self._AllowSandboxMode() _AllowSandboxMode at /b/build/slave/orderfile-clankium/build/src/clank/tools/orderfile_generator.py:414 'Expected 1, found %d.' % num_replacements) Exception: Unexpected number of occurrences of android:isolatedProcess="true" in AndroidManifest.xml. Expected 1, found 2. Locals: f : <closed file '/b/build/slave/orderfile-clankium/build/src/chrome/android/java/AndroidManifest.xml', mode 'r' at 0x7f5bb601c8a0> manifest : '<?xml version="1.0" encoding="utf-8"?>\n<!-- Copyright 2015 The Chromium Authors. All rights reserved.\n Use of this source code is governed by a BSD-style license that can be\n found in the LICENSE file. -->\n\n<!--\nNote: This is a jinja2 template, processed at build time into the final manifest.\n\nBlocks denoted with { % block some_name % }foo{ % endblock % } can be overridden\nby a child template that "extends" this file.\n-->\n\n<manifest xmlns:android="http://schemas.android.com/apk/res/a ... nt.\n The most specific MediaRouteControllers should be listed first, followed by more generic ones.\n The downstream manifest replaces this block, and hence replaces the list of media route\n controllers with its own list. -->\n <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYERS"\n android:value="org.chromium.chrome.browser.media.remote.DefaultMediaRouteController"/>\n\n {% endblock %}\n </application>\n</manifest>\n' (truncated) num_replacements : 2
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11faf12d156f25a7d8cbe0c87b44d19090e56542 commit 11faf12d156f25a7d8cbe0c87b44d19090e56542 Author: aelias <aelias@chromium.org> Date: Mon May 01 16:57:28 2017 Revert of Photo Picker Dialog: Use sandboxed utility process for decoding images. (patchset #11 id:240001 of https://codereview.chromium.org/2816733002/ ) Reason for revert: generate_orderfiles.py fails due to AndroidManifest.xml change (see http://crbug.com/717071 ) BUG= 717071 Original issue's description: > Photo Picker Dialog: Use sandboxed utility process for decoding images. > > BUG= 656015 > > Review-Url: https://codereview.chromium.org/2816733002 > Cr-Commit-Position: refs/heads/master@{#468209} > Committed: https://chromium.googlesource.com/chromium/src/+/83c9f3f4faeb35a3a2607446def65f1a8da7aa49 TBR=twellington@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,finnur@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 656015 Review-Url: https://codereview.chromium.org/2853793003 Cr-Commit-Position: refs/heads/master@{#468330} [modify] https://crrev.com/11faf12d156f25a7d8cbe0c87b44d19090e56542/chrome/android/java/AndroidManifest.xml [delete] https://crrev.com/5ac2cb3b42596a71378b03f544bf37daba34aa93/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/BitmapUtils.java [delete] https://crrev.com/5ac2cb3b42596a71378b03f544bf37daba34aa93/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java [delete] https://crrev.com/5ac2cb3b42596a71378b03f544bf37daba34aa93/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceHost.java [modify] https://crrev.com/11faf12d156f25a7d8cbe0c87b44d19090e56542/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/MimeTypeFileFilter.java [modify] https://crrev.com/11faf12d156f25a7d8cbe0c87b44d19090e56542/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java [modify] https://crrev.com/11faf12d156f25a7d8cbe0c87b44d19090e56542/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapViewHolder.java [modify] https://crrev.com/11faf12d156f25a7d8cbe0c87b44d19090e56542/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java [modify] https://crrev.com/11faf12d156f25a7d8cbe0c87b44d19090e56542/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/11faf12d156f25a7d8cbe0c87b44d19090e56542/chrome/android/java_sources.gni
,
May 1 2017
,
May 2 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/bb9fef5b35b543374c802af75208196b8d264591 commit bb9fef5b35b543374c802af75208196b8d264591 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Tue May 02 17:56:21 2017 |
||
►
Sign in to add a comment |
||
Comment 1 by aelias@chromium.org
, May 1 2017