New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717069 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

R58 Branch Pre-Flight Failing with 'Could not find appropriate AFDO profile'

Project Member Reported by bhthompson@google.com, May 1 2017

Issue description

The R58 pre flight builder is failing the AFDOUpdateEbuild phase

https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R58-9334.B/builds/260/steps/AFDOUpdateEbuild/logs/stdio
...
20:16:08: INFO: Found latest AFDO info file gs://chromeos-prebuilt/afdo-job/llvm/latest-chromeos-chrome-amd64-57.afdo but it is too old

@@@STEP_FAILURE@@@
20:16:08: ERROR: Could not find appropriate AFDO profile
...

Do we need a workaround like https://chromium-review.googlesource.com/#/c/373683/1 ?

We appear to still be getting Chrome uprevs, so it is not clear how critical this is, it implies we are missing AFDO optimization?
 
Labels: Build-Toolchain
Owner: laszio@chromium.org
Status: Assigned (was: Untriaged)
yes, we need to apply that workaround.. 
Assigning to Ting-Yuan.
Ting-Yuan and I will discuss on a better way to handle this so that we can avoid having to do this for some branches.

This happens because there is no builder generating the profile. In R58, it is only used for 4 boards so we decided not to set up a dedicated builder. The solution discussed was to generate it manually. However, we forgot the staleness requirement so you saw the failure :(

I've triggered a build to generate the profile and that will keep samus-pre-flight-branch happy in the next two weeks. Let me write this to crontab to generate it daily.
Labels: Merge-Request-58
Per discussed with Luis, I've created a CL to make AFDO profiles never expire on R58:

https://chromium-review.googlesource.com/c/492488/
Labels: -Merge-Request-58 Merge-Approved-58
Project Member

Comment 5 by bugdroid1@chromium.org, May 1 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0bc938a54e8b319ca4d0a66fbced74f273e61dd8

commit 0bc938a54e8b319ca4d0a66fbced74f273e61dd8
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Mon May 01 23:53:17 2017

AutoFDO: extend the expiration days to 8 weeks.

This basically make it never expire, assuming R58 will roughly live for
6 weeks.

TEST=none
BUG= chromium:717069 

Change-Id: I009e4e83e03f782e6515bddd90733c9db10ac68b
Reviewed-on: https://chromium-review.googlesource.com/492488
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/0bc938a54e8b319ca4d0a66fbced74f273e61dd8/cbuildbot/afdo.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Labels: -Merge-Approved-58

Sign in to add a comment