Once we have Network Settings available in OOBE / Login, we should integrate the ChooseMobileNetwork UI (chrome://choose-mobile-network) into the Settings UI.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/354f2b28ebc9ec72b9a127cac2e043975a7939a9 commit 354f2b28ebc9ec72b9a127cac2e043975a7939a9 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Sep 06 23:58:41 2017 NetworkHandler / networkingPrivate: Support network scan by type Bug: 717063 Change-Id: I94fb06a499a160534e840a0dd273a4ffe936e4ff Reviewed-on: https://chromium-review.googlesource.com/639573 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#500145} [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chrome/test/data/extensions/api_test/networking_private/test.js [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/dbus/fake_shill_device_client.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/dbus/fake_shill_device_client.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/dbus/fake_shill_manager_client.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/dbus/shill_device_client.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/network/auto_connect_handler.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/network/network_state_handler.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/network/network_state_handler.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/network/network_state_handler_unittest.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/network/shill_property_handler.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/chromeos/network/shill_property_handler.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/components/arc/net/arc_net_host_impl.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_api.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_chromeos.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_chromeos.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_delegate.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_linux.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_linux.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_service_client.cc [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/browser/api/networking_private/networking_private_service_client.h [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/common/api/networking_onc.idl [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/common/api/networking_private.idl [modify] https://crrev.com/354f2b28ebc9ec72b9a127cac2e043975a7939a9/extensions/shell/browser/shell_network_controller_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5 commit 3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Sep 12 18:16:49 2017 NetworkStateHandler: Add EnsureCellularNetwork This CL provide support for Cellular devices with no service: * Cellular networks all use the same specifier so that the guid remains consistent (we only support one Cellular Service) * Assume a SIM may be present unless Cellular.NetworkTechnology is CDMA so that the SIM UI shows up even if NetworkTechnology is unset (e.g. because there is no Service). * Create a dummy Cellular NetworkState when none exists so that Cellular Device properties are translated and passed to the UI. This also allows Cellular network UI to be shown so that Device properties can be viewed and SIM and FoundNetworks may be selected. Bug: 717063 Change-Id: I1e23e7ba48821124ad219bb67fea2ca86e2d6ccd Reviewed-on: https://chromium-review.googlesource.com/653723 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#501337} [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/ash/system/network/network_icon.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/ash/system/network/network_icon_unittest.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/dbus/fake_shill_manager_client.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/device_state.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/network_configuration_handler.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/network_state.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/network_state.h [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/network_state_handler.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/network_state_handler.h [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/network_state_handler_unittest.cc [modify] https://crrev.com/3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5/chromeos/network/onc/onc_translator_shill_to_onc.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef commit 2c0ea56f7967b3d1f95a3042204aaeaa0de78cef Author: Bruce Dawson <brucedawson@chromium.org> Date: Tue Sep 12 21:51:03 2017 Revert "NetworkStateHandler: Add EnsureCellularNetwork" This reverts commit 3b6c1aa73e3b4cb02e8f6eba48b1f945ccef9bb5. Reason for revert: SUMMARY: AddressSanitizer: heap-use-after-free chromeos/network/network_state.h:56:33 in visible Original change's description: > NetworkStateHandler: Add EnsureCellularNetwork > > This CL provide support for Cellular devices with no service: > * Cellular networks all use the same specifier so that the guid > remains consistent (we only support one Cellular Service) > * Assume a SIM may be present unless Cellular.NetworkTechnology > is CDMA so that the SIM UI shows up even if NetworkTechnology > is unset (e.g. because there is no Service). > * Create a dummy Cellular NetworkState when none exists so that > Cellular Device properties are translated and passed to the UI. > This also allows Cellular network UI to be shown so that > Device properties can be viewed and SIM and FoundNetworks may > be selected. > > Bug: 717063 > Change-Id: I1e23e7ba48821124ad219bb67fea2ca86e2d6ccd > Reviewed-on: https://chromium-review.googlesource.com/653723 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Ben Chan <benchan@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501337} TBR=stevenjb@chromium.org,benchan@chromium.org,khorimoto@chromium.org Change-Id: I073a95d8160812923cbcc192f0afe934db672a40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717063 Reviewed-on: https://chromium-review.googlesource.com/662958 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501412} [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/ash/system/network/network_icon.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/ash/system/network/network_icon_unittest.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/dbus/fake_shill_manager_client.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/device_state.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/network_configuration_handler.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/network_state.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/network_state.h [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/network_state_handler.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/network_state_handler.h [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/network_state_handler_unittest.cc [modify] https://crrev.com/2c0ea56f7967b3d1f95a3042204aaeaa0de78cef/chromeos/network/onc/onc_translator_shill_to_onc.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa312b778f668d1c9576da18969efcb3576d6f77 commit fa312b778f668d1c9576da18969efcb3576d6f77 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Sep 13 00:59:52 2017 networkingPrivate: Introduce selectCellularMobileNetwork This adds support to networkingPrivate for selecting a Cellular mobile network. BUG= 717063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2cc89aaceae25e73d177cfdcb44e58912a5bbc2d Reviewed-on: https://chromium-review.googlesource.com/646571 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501493} [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/chrome/test/data/extensions/api_test/networking_private/test.js [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/chrome/test/data/webui/settings/fake_networking_private.js [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/chromeos/dbus/fake_shill_device_client.cc [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_api.cc [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_api.h [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_chromeos.cc [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_chromeos.h [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_delegate.h [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_linux.cc [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_linux.h [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_service_client.cc [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/api/networking_private/networking_private_service_client.h [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/extensions/common/api/networking_private.idl [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/third_party/closure_compiler/externs/networking_private.js [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/third_party/closure_compiler/interfaces/networking_private_interface.js [modify] https://crrev.com/fa312b778f668d1c9576da18969efcb3576d6f77/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fa1cb374572fa76bf6b078fcc8d706fa669936f commit 5fa1cb374572fa76bf6b078fcc8d706fa669936f Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Sep 14 20:16:05 2017 NetworkStateHandler: Add EnsureCellularNetwork (Take 2) This CL provide support for Cellular devices with no service: * Cellular networks all use the same specifier so that the guid remains consistent (we only support one Cellular Service) * Assume a SIM may be present unless Cellular.NetworkTechnology is CDMA so that the SIM UI shows up even if NetworkTechnology is unset (e.g. because there is no Service). * Create a dummy Cellular NetworkState when none exists so that Cellular Device properties are translated and passed to the UI. This also allows Cellular network UI to be shown so that Device properties can be viewed and SIM and FoundNetworks may be selected. + Fix AutoConnectHandler::DisconnectFromUnmanagedSharedWiFiNetworks (bug found in ASAN tests) Previously reviewed at: crrev.com/c/653723 Bug: 717063 Change-Id: Ie54e90b57a9b0453fb4b7ba2853b498d93d7b27b TBR: khorimoto@chromium.org,benchan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/666978 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502030} [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/ash/system/network/network_icon.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/ash/system/network/network_icon_unittest.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/dbus/fake_shill_manager_client.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/auto_connect_handler.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/device_state.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/network_configuration_handler.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/network_state.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/network_state.h [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/network_state_handler.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/network_state_handler.h [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/network_state_handler_unittest.cc [modify] https://crrev.com/5fa1cb374572fa76bf6b078fcc8d706fa669936f/chromeos/network/onc/onc_translator_shill_to_onc.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b202947ed8956b456dd37e513953895667be35f3 commit b202947ed8956b456dd37e513953895667be35f3 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Sep 18 19:43:56 2017 CrOS: Default Cellular: Set name and handle correctly in tray This also includes additional changes to handle Cellular correctly and reduce log spam. Bug: 717063 Change-Id: I9f30eadf082104e7b5a9e904707b7d1e2d885ca9 Reviewed-on: https://chromium-review.googlesource.com/668740 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#502647} [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/managed_network_configuration_handler_impl.cc [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/network_connection_handler_impl.cc [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/network_state.cc [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/network_state.h [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/network_state_handler.cc [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/network_type_pattern.cc [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/proxy/ui_proxy_config_service.cc [modify] https://crrev.com/b202947ed8956b456dd37e513953895667be35f3/chromeos/network/shill_property_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a31eb88b9bd28b64f15311adb93e3eeb3b84d243 commit a31eb88b9bd28b64f15311adb93e3eeb3b84d243 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Sep 19 18:55:48 2017 Integrate choose mobile network with Settings UI Bug: 717063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5a87911a835f0ef29f49b66d9cd0dfd9da5eb041 Reviewed-on: https://chromium-review.googlesource.com/656379 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#502904} [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chrome/app/settings_strings.grdp [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chrome/browser/resources/chromeos/internet_detail_dialog.html [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chrome/browser/resources/chromeos/internet_detail_dialog.js [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chromeos/network/onc/onc_signature.cc [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/chromeos/network/onc/onc_translation_tables.cc [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/components/onc/docs/onc_spec.md [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/components/onc/onc_constants.cc [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/components/onc/onc_constants.h [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/extensions/common/api/networking_onc.idl [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/extensions/common/api/networking_private.idl [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/third_party/closure_compiler/externs/networking_private.js [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/ui/webui/resources/cr_components/chromeos/network/compiled_resources2.gyp [add] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.html [add] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.js [modify] https://crrev.com/a31eb88b9bd28b64f15311adb93e3eeb3b84d243/ui/webui/resources/cr_components/cr_components_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5a81099a611b7c62d50c0f90fe8b73e551ed621 commit b5a81099a611b7c62d50c0f90fe8b73e551ed621 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Sep 19 20:16:33 2017 OOBE: Remove 'Add other mobile network' This is now part of the details dialog for the Cellular network. BUG= 717063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib221c819fe0f76220d7bbd88d30525df171581a7 Reviewed-on: https://chromium-review.googlesource.com/669952 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502934} [modify] https://crrev.com/b5a81099a611b7c62d50c0f90fe8b73e551ed621/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/b5a81099a611b7c62d50c0f90fe8b73e551ed621/chrome/browser/resources/chromeos/internet_detail_dialog.html [modify] https://crrev.com/b5a81099a611b7c62d50c0f90fe8b73e551ed621/chrome/browser/resources/chromeos/internet_detail_dialog.js [modify] https://crrev.com/b5a81099a611b7c62d50c0f90fe8b73e551ed621/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/b5a81099a611b7c62d50c0f90fe8b73e551ed621/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc [modify] https://crrev.com/b5a81099a611b7c62d50c0f90fe8b73e551ed621/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h [modify] https://crrev.com/b5a81099a611b7c62d50c0f90fe8b73e551ed621/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d8ca3a18a716fd187df7e34a281aede34967c76 commit 0d8ca3a18a716fd187df7e34a281aede34967c76 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Sep 20 16:11:21 2017 Remove ChooseMobileNetwork This UI has been replaced with the internet detail dialog and can now be removed. Bug: 717063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I77ee0a6c82728d21f66cc7fc5191d1966ed4bc90 For trivial code removal: TBR=sky@chromium.org,xiyuan@chromium.org Change-Id: I77ee0a6c82728d21f66cc7fc5191d1966ed4bc90 Reviewed-on: https://chromium-review.googlesource.com/671460 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#503170} [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/browser_resources.grd [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/chromeos/status/network_menu.cc [delete] https://crrev.com/e535de89cb7f32fe90da6039b399d7716368af6f/chrome/browser/chromeos/ui/choose_mobile_network_dialog.cc [delete] https://crrev.com/e535de89cb7f32fe90da6039b399d7716368af6f/chrome/browser/chromeos/ui/choose_mobile_network_dialog.h [delete] https://crrev.com/e535de89cb7f32fe90da6039b399d7716368af6f/chrome/browser/resources/chromeos/choose_mobile_network.css [delete] https://crrev.com/e535de89cb7f32fe90da6039b399d7716368af6f/chrome/browser/resources/chromeos/choose_mobile_network.html [delete] https://crrev.com/e535de89cb7f32fe90da6039b399d7716368af6f/chrome/browser/resources/chromeos/choose_mobile_network.js [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/resources/settings/internet_page/internet_subpage.js [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/ui/ash/system_tray_client.cc [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/ui/webui/chromeos/OWNERS [delete] https://crrev.com/e535de89cb7f32fe90da6039b399d7716368af6f/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc [delete] https://crrev.com/e535de89cb7f32fe90da6039b399d7716368af6f/chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.h [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/browser/ui/webui/settings/chromeos/internet_handler.cc [modify] https://crrev.com/0d8ca3a18a716fd187df7e34a281aede34967c76/chrome/common/url_constants.cc
Issue 756791 has been merged into this issue.
Comment 1 by steve...@chromium.org
, Jun 26 2017