FirstUserAction.BackgroundTime.MainIntent inaccurate for zero tabs case |
||||||
Issue descriptionWhen there are zero tabs, Chrome creates a new tab, which was accounted for and ignored, but then also triggers the path to select the tab. The tab selection process resulted in all main intents with zero tabs as being reported as FirstUserAction.BackgroundTime.MainIntent.SwitchTabs.
,
May 2 2017
,
May 15 2017
Merge request for this as it will make the merge for 717754 cleaner and the behavior in the change was small relative to the amount of test size increase.
,
May 15 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe commit b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe Author: Ted Choc <tedchoc@google.com> Date: Mon May 15 20:25:24 2017 Fix main intent metrics when zero tabs present. The previous ignore logic was incorrect as it was both calling create and set index. Thus the zero tabs case was resulting in switch tabs always. Adds tests to catch regressions going forward. BUG= 717062 Review-Url: https://codereview.chromium.org/2850163002 Cr-Original-Commit-Position: refs/heads/master@{#468493} Review-Url: https://codereview.chromium.org/2880253003 . Cr-Commit-Position: refs/branch-heads/3071@{#565} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe/chrome/android/java/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetrics.java [modify] https://crrev.com/b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe/chrome/android/java_sources.gni [add] https://crrev.com/b9958d0e3c2b58bd8992b5a1eb47d8d1a65428fe/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetricsIntegrationTest.java
,
Nov 13 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, May 1 2017