New issue
Advanced search Search tips

Issue 717057 link

Starred by 1 user
Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

browser_tests failing on 2 builders

Project Member Reported by rogerta@chromium.org, May 1 2017 
browser_tests failing on 2 builders

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
 https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

- Linux MSan Tests: 
 https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests

Failure:
browser_tests browser_tests
Run on OS: 'Ubuntu-14.04'
failures:
RequestFileSystemDialogTest.InvokeDialog_default

First build to see this error:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/20886

Problematic commit:
https://chromium.googlesource.com/chromium/src/+/5ecf11b9c4f09559336a513b4d0486a3f74d2625

Replace layout constants in chrome/browser/extensions and chrome/browser/first_run

Ananta: if you can't find a quick fox can you please revert as you investigate?  Thanks.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eb55d6c752c6046493edcaf4fbcf222712211e9

commit 0eb55d6c752c6046493edcaf4fbcf222712211e9
Author: ananta <ananta@chromium.org>
Date: Tue May 02 12:30:42 2017

Fix the memory leak in the RequestFileSystemDialogTest reported by the Chrome OS ASAN builder.

The RequestFileSystemDialogView class had an unused member contents_view_ which is no longer needed after https://codereview.chromium.org/2816293002/diff/520001.

Removing this should fix the memory leak. Thanks to lazyboy for helping track down this leak.

BUG=717057
TBR=pkasting

Review-Url: https://codereview.chromium.org/2855663002
Cr-Commit-Position: refs/heads/master@{#468607}

[modify] https://crrev.com/0eb55d6c752c6046493edcaf4fbcf222712211e9/chrome/browser/ui/views/extensions/request_file_system_dialog_view.cc
[modify] https://crrev.com/0eb55d6c752c6046493edcaf4fbcf222712211e9/chrome/browser/ui/views/extensions/request_file_system_dialog_view.h

Comment 2 by robliao@chromium.org, Aug 21

Owner: ----
Status: Untriaged (was: Assigned)
Unassigning all bugs for ananta@chromium.org
►

Sign in to add a comment