New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717030 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ImageLoader is crashing on arm and intel devices

Project Member Reported by kerrnel@chromium.org, May 1 2017

Issue description

ImageLoader started crashing on arm and intel devices. See:

https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=platform_ImageLoaderServer

The system logs show:

WARNING kernel: [  131.021179] init: imageloader main process (3637) killed by ABRT signal

This is often caused by seccomp failures but could be caused anything.
 
Cc: kerrnel@chromium.org ihf@chromium.org
Components: Internals>Installer>Components
Labels: OS-Chrome
Owner: ejcaruso@chromium.org
Status: Assigned (was: Untriaged)
Eric, could this be related to some of the recent CLs that went into ImageLoader?

Comment 2 by ihf@chromium.org, May 1 2017

It is a double regression in this range
https://crosland.corp.google.com/log/9502.0.0..9505.0.0

Could this be responsible for ARM?
https://chromium-review.googlesource.com/#/c/490446/
That's mtpd, not ImageLoader, right?
Are you sure this is happening on ARM boards? It looks like all the failures in the wmatrix link are intel.
Also, there are no imageloader CLs in the range specified in c#2. The only CLs I put in relate to a debugd refactor which shouldn't have any effect on imageloader.

I'm not sure why any of the CLs in that range should have caused an issue, but everything does look pretty green before 9502...
Project Member

Comment 6 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/d80e3eca9bbd0b0e9dbd26f39a018f02f224d45a

commit d80e3eca9bbd0b0e9dbd26f39a018f02f224d45a
Author: Greg Kerr <kerrnel@chromium.org>
Date: Tue May 02 02:18:18 2017

Initialize OpenSSL temporary pointer to nullptr.

Per https://www.openssl.org/docs/faq.html#PROG3, the temporary
variable passed to i2d_PUBKEY must be initialized to NULL,
or the OpenSSL API thinks it is a valid buffer that was
already allocated.

BUG= chromium:717030 
TEST=autotest platform_ImageLoaderServer

Change-Id: I77c668f2da3346a77be8c0efbbd3185a217de0fd
Reviewed-on: https://chromium-review.googlesource.com/491989
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d80e3eca9bbd0b0e9dbd26f39a018f02f224d45a/imageloader_main.cc

Cc: -ihf@chromium.org ejcaruso@chromium.org
Owner: ihf@chromium.org
reassigning while you look at this
Failed: download-omaha-component.

Something is going wrong there, pretty much every board is failing. What the heck.
Cc: waff...@chromium.org
I reproduced on my Samus. waffles@ thinks this is the bug fixed in https://codereview.chromium.org/2856573003/ and we should see the tests go green once Chrome rolls to the latest canary.

Comment 11 by ihf@chromium.org, May 4 2017

Waiting for 60.0.3087.0...

Comment 12 by ihf@chromium.org, May 8 2017

Status: Verified (was: Assigned)
I need to add expectations for veyron_rialto and guado/moblab which don't have Flash. Otherwise green.

Sign in to add a comment