New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Event Queueing and Blocking Time metrics broken for non-touch input

Project Member Reported by tdres...@chromium.org, May 1 2017

Issue description

If the most recent touch start event was prevented, we'll consider all events (including non-touch events) blocking.
 
Cc: tdres...@chromium.org
Owner: nzolghadr@chromium.org
Navid, could you take a look at this at some point?

It's a trivial fix, this line is wrong: https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc?rcl=62809a64d70ec8b67847b3cefc03e4ba4bda0d3f&l=140, and should special case touch input.
Ping.

(Triaging Chrome Speed Metrics bugs)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40ed50386c66eeb21c65bad6225435910e00686c

commit 40ed50386c66eeb21c65bad6225435910e00686c
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Wed Oct 11 16:04:19 2017

Fix event name in metrics for non-touch events

When touch start is prevented before this patch
the code was mistakenly considered all the events
including non-touch events as DefaultPrevented.

Bug:  717017 
Change-Id: I0928ddb184a79b95c3502cb3a9f4f4f1b4fed267
Reviewed-on: https://chromium-review.googlesource.com/705280
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507993}
[modify] https://crrev.com/40ed50386c66eeb21c65bad6225435910e00686c/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc

Status: Fixed (was: Assigned)

Sign in to add a comment