New issue
Advanced search Search tips

Issue 717010 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

28.7kb regression in resource_sizes (MonochromePublic.apk) at 467866:467866

Project Member Reported by estevenson@chromium.org, May 1 2017

Issue description

Caused by: Enable module scripts in ScriptLoader
https://codereview.chromium.org/2781713003
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=717010

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg0u679AoM


Bot(s) for this bug's original alert(s):

Android Builder
Owner: hirosh...@chromium.org
Status: Assigned (was: Untriaged)
Is this an expected outcome of this change? Could the code be improved at all to eliminate the size jump?


Partial symbol diff (via tools/binary_size/diagnose_apk_bloat.py):

267 symbols added (+), 94 changed (~), 12 removed (-), 318023 unchanged (not shown)
10 object files added, 0 removed

Showing 373 symbols with total size: 28788 bytes
.text=27.0kb     .rodata=320 bytes  other=848 bytes  total=28.1kb
Number of object files: 107

First columns are: running total, type, size
+     1608 t@0x1135368  1608    v8/v8_base/objects.o
               v8::internal::Module::ResolveExport
+     2956 t@0x1135a28  1348    v8/v8_base/objects.o
               v8::internal::Module::FinishInstantiate
+     3848 t@0x1fc190c  892     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               blink::ModuleTreeLinker::UninstantiatedInclusiveDescendants
+     4732 t@0x1134cec  884     v8/v8_base/objects.o
               v8::internal::Module::PrepareInstantiate
+     5544 t@0x10790ac  812     v8/v8_base/factory.o
               v8::internal::Factory::NewModule
+     6324 t@0x1fc1dac  780     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               blink::ModuleTreeLinker::FetchDescendants
+     7092 r@0x2bfb560  768     third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/locale_android.o
+     7756 t@0x11350d0  664     v8/v8_base/objects.o
               v8::internal::Module::ResolveExportUsingStarExports
+     8396 t@0x112d064  640     v8/v8_base/objects.o
               v8::internal::Module::Evaluate
+     8920 t@0xe7f888   524     v8/v8_base/api.o
               v8::Module::Evaluate
+     9420 t@0x1b67878  500     third_party/WebKit/Source/core/libcore_generated.a/V8ScriptRunner.o
               blink::V8ScriptRunner::CompileModule
+     9896 t@0x1d99a84  476     third_party/WebKit/Source/core/dom/libdom_3.a/ScriptModuleResolverImpl.o
               blink::ScriptModuleResolverImpl::Resolve
+    10332 t@0x1d86b04  436     third_party/WebKit/Source/core/dom/libdom_2.a/ModulatorImpl.o
               blink::ModulatorImpl::ModulatorImpl
~     9948 r@0x2bfa254  -384    third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/hash.o
+    10332 t@0x1d878a8  384     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               blink::ModuleMap::FetchSingleModuleScript
~     9956 r@0x2b92eb8  -376    components/subresource_filter/content/renderer/librenderer.a/subresource_filter_agent.o
~    10321 r@Group      365     {{no path}}
               ** merge strings (count=6)
+    10673 t@0xe7fa94   352     v8/v8_base/api.o
               v8::Module::Instantiate
+    11015 t@0x1b5b1b8  342     third_party/WebKit/Source/core/libcore_generated.a/ScriptModule.o
               blink::ScriptModule::ResolveModuleCallback
+    11347 t@0x1134ad4  332     v8/v8_base/objects.o
               v8::internal::Module::CreateExport
+    11669 t@0x1fc0a10  322     third_party/WebKit/Source/core/loader/libloader.a/ModuleScriptLoader.o
               blink::ModuleScriptLoader::Fetch
+    11989 t@0x1d87014  320     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               blink::ModuleMap::Entry::DispatchFinishedNotificationAsync
+    12289 t@0x1fc0864  300     third_party/WebKit/Source/core/loader/libloader.a/ModuleScriptLoader.o
               blink::ModuleScriptLoader::CreateModuleScript
+    12565 t@0x1d99ddc  276     third_party/WebKit/Source/core/dom/libdom_3.a/ScriptModuleResolverImpl.o
               WTF::HashTable<blink::ScriptModule, WTF::KeyValuePair<blink::ScriptModule, blink::Member<blink::ModuleScript> >, WTF::KeyValuePairKeyExtractor, blink::ScriptModuleHash, WTF::HashMapValueTraits<WTF::HashTraits<blink::ScriptModule>, WTF::HashTraits<blink::Member<blink::ModuleScript> > >, WTF::HashTraits<blink::ScriptModule>, blink::HeapAllocator>::Expand
+    12831 t@0x1d8779e  266     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               WTF::HashTable<blink::KURL, WTF::KeyValuePair<blink::KURL, blink::TraceWrapperMember<blink::ModuleMap::Entry> >, WTF::KeyValuePairKeyExtractor, blink::KURLHash, WTF::HashMapValueTraits<WTF::HashTraits<blink::KURL>, WTF::HashTraits<blink::TraceWrapperMember<blink::ModuleMap::Entry> > >, WTF::HashTraits<blink::KURL>, blink::HeapAllocator>::Expand
+    13097 t@0x1fc0d9c  266     third_party/WebKit/Source/core/loader/libloader.a/ModuleScriptLoaderRegistry.o
               blink::ModuleScriptLoaderRegistry::Fetch
+    13359 t@0x1d99ef0  262     third_party/WebKit/Source/core/dom/libdom_3.a/ScriptModuleResolverImpl.o
               blink::ScriptModuleResolverImpl::RegisterModuleScript
-    13099 t@0x1132f0c  -260    v8/v8_base/objects.o
               std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> >, std::__ndk1::__unordered_map_hasher<v8::internal::Handle<v8::internal::String>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> >, v8::internal::StringHandleHash, true>, std::__ndk1::__unordered_map_equal<v8::internal::Handle<v8::internal::String>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> >, v8::internal::StringHandleEqual, true>, v8::internal::ZoneAllocator<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> > > >::__rehash
+    13359 t@0x1133fd4  260     v8/v8_base/objects.o
               std::__ndk1::__hash_table<v8::internal::Handle<v8::internal::String>, v8::internal::StringHandleHash, v8::internal::StringHandleEqual, v8::internal::ZoneAllocator<v8::internal::Handle<v8::internal::String> > >::__rehash
+    13615 t@0x1fc180c  256     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               WTF::Deque<blink::Member<blink::ModuleScript>, 0u, blink::HeapAllocator>::ExpandCapacity
+    13871 t@0x1fc1450  256     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               WTF::HashTable<blink::KURL, blink::KURL, WTF::IdentityExtractor, blink::KURLHash, WTF::HashTraits<blink::KURL>, WTF::HashTraits<blink::KURL>, WTF::PartitionAllocator>::Rehash
+    14123 t@0xe72ae0   252     v8/v8_base/api.o
               v8::Module::GetModuleRequest const
+    14363 t@0x1d87154  240     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               blink::ModuleMap::Entry::NotifyNewSingleModuleFinished
+    14599 t@0x1d86714  236     third_party/WebKit/Source/core/dom/libdom_2.a/Modulator.o
               blink::Modulator::ResolveModuleSpecifier
+    14831 t@0x111d5b8  232     v8/v8_base/objects.o
               std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*>, std::__ndk1::__unordered_map_hasher<v8::internal::Handle<v8::internal::Module>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*>, v8::internal::ModuleHandleHash, true>, std::__ndk1::__unordered_map_equal<v8::internal::Handle<v8::internal::Module>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*>, v8::internal::ModuleHandleEqual, true>, v8::internal::ZoneAllocator<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*> > >::rehash
+    15051 t@0x1d876c2  220     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               WTF::HashTable<blink::KURL, WTF::KeyValuePair<blink::KURL, blink::TraceWrapperMember<blink::ModuleMap::Entry> >, WTF::KeyValuePairKeyExtractor, blink::KURLHash, WTF::HashMapValueTraits<WTF::HashTraits<blink::KURL>, WTF::HashTraits<blink::TraceWrapperMember<blink::ModuleMap::Entry> > >, WTF::HashTraits<blink::KURL>, blink::HeapAllocator>::RehashTo
+    15271 t@0x1fc1c88  220     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               blink::ModuleTreeLinker::Instantiate
+    15487 t@0x1d99d04  216     third_party/WebKit/Source/core/dom/libdom_3.a/ScriptModuleResolverImpl.o
               WTF::HashTable<blink::ScriptModule, WTF::KeyValuePair<blink::ScriptModule, blink::Member<blink::ModuleScript> >, WTF::KeyValuePairKeyExtractor, blink::ScriptModuleHash, WTF::HashMapValueTraits<WTF::HashTraits<blink::ScriptModule>, WTF::HashTraits<blink::Member<blink::ModuleScript> > >, WTF::HashTraits<blink::ScriptModule>, blink::HeapAllocator>::RehashTo
+    15699 t@0x1fc0ea4  212     third_party/WebKit/Source/core/loader/libloader.a/ModuleScriptLoaderRegistry.o
               blink::ModuleScriptLoaderRegistry::ReleaseFinishedLoader
+    15911 t@0x1fc249c  212     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinkerRegistry.o
               blink::ModuleTreeLinkerRegistry::ReleaseFinishedFetcher
+    16123 t@0x1d98bb8  212     third_party/WebKit/Source/core/dom/libdom_3.a/ScriptLoader.o
               blink::ScriptLoader::FetchModuleScriptTree
~    16335 t@0x1d99380  212     third_party/WebKit/Source/core/dom/libdom_3.a/ScriptLoader.o
               blink::ScriptLoader::PrepareScript [clone .part.75]
+    16543 t@0x1fc135c  208     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               WTF::HashTable<blink::Member<blink::ModuleScript>, blink::Member<blink::ModuleScript>, WTF::IdentityExtractor, WTF::MemberHash<blink::ModuleScript>, WTF::HashTraits<blink::Member<blink::ModuleScript> >, WTF::HashTraits<blink::Member<blink::ModuleScript> >, blink::HeapAllocator>::Expand
+    16751 t@0x1fc11c4  208     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               WTF::HashTable<blink::Member<blink::ModuleTreeLinker::DependencyModuleClient>, blink::Member<blink::ModuleTreeLinker::DependencyModuleClient>, WTF::IdentityExtractor, WTF::MemberHash<blink::ModuleTreeLinker::DependencyModuleClient>, WTF::HashTraits<blink::Member<blink::ModuleTreeLinker::DependencyModuleClient> >, WTF::HashTraits<blink::Member<blink::ModuleTreeLinker::DependencyModuleClient> >, blink::HeapAllocator>::Expand
+    16959 t@0x1d8728c  208     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               WTF::HashTable<blink::Member<blink::SingleModuleClient>, blink::Member<blink::SingleModuleClient>, WTF::IdentityExtractor, WTF::MemberHash<blink::SingleModuleClient>, WTF::HashTraits<blink::Member<blink::SingleModuleClient> >, WTF::HashTraits<blink::Member<blink::SingleModuleClient> >, blink::HeapAllocator>::Expand
+    17167 t@0x1fc0b50  208     third_party/WebKit/Source/core/loader/libloader.a/ModuleScriptLoader.o
               blink::ModuleScriptLoader::ModuleScriptLoader
+    17375 t@0x111d0fc  208     v8/v8_base/objects.o
               std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*>, std::__ndk1::__unordered_map_hasher<v8::internal::Handle<v8::internal::Module>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*>, v8::internal::ModuleHandleHash, true>, std::__ndk1::__unordered_map_equal<v8::internal::Handle<v8::internal::Module>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*>, v8::internal::ModuleHandleEqual, true>, v8::internal::ZoneAllocator<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::Module>, v8::internal::UnorderedStringSet*> > >::__rehash [clone .part.332]
+    17579 t@0x1fc170c  204     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               WTF::Vector<blink::Member<blink::ModuleScript>, 0u, blink::HeapAllocator>::ReserveCapacity
+    17783 t@0x1134c20  204     v8/v8_base/objects.o
               v8::internal::Module::CreateIndirectExport
+    17975 t@0x1d86cb8  192     third_party/WebKit/Source/core/dom/libdom_2.a/ModulatorImpl.o
               blink::ModulatorImpl::Create
+    18167 t@0x1d875dc  192     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               blink::ModuleMap::GetFetchedModuleScript const
-    17975 t@0x1133010  -192    v8/v8_base/objects.o
               std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> >, std::__ndk1::__unordered_map_hasher<v8::internal::Handle<v8::internal::String>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> >, v8::internal::StringHandleHash, true>, std::__ndk1::__unordered_map_equal<v8::internal::Handle<v8::internal::String>, std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> >, v8::internal::StringHandleEqual, true>, v8::internal::ZoneAllocator<std::__ndk1::__hash_value_type<v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::Object> > > >::rehash
+    18167 t@0x11340d8  192     v8/v8_base/objects.o
               std::__ndk1::__hash_table<v8::internal::Handle<v8::internal::String>, v8::internal::StringHandleHash, v8::internal::StringHandleEqual, v8::internal::ZoneAllocator<v8::internal::Handle<v8::internal::String> > >::rehash
+    18353 t@0x132f750  186     third_party/WebKit/Source/platform/platform/V8PerContextData.o
               blink::V8PerContextData::AddData
+    18537 t@0x132f66e  184     third_party/WebKit/Source/platform/platform/V8PerContextData.o
               WTF::HashTable<char const*, WTF::KeyValuePair<char const*, blink::Member<blink::V8PerContextData::Data> >, WTF::KeyValuePairKeyExtractor, WTF::PtrHash<char const>, WTF::HashMapValueTraits<WTF::HashTraits<char const*>, WTF::HashTraits<blink::Member<blink::V8PerContextData::Data> > >, WTF::HashTraits<char const*>, blink::HeapAllocator>::Rehash
+    18721 t@0x1d87ec4  184     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleScript.o
               blink::ModuleScript::SetInstantiationErrorAndClearRecord
+    18901 t@0x1fc0cbc  180     third_party/WebKit/Source/core/loader/libloader.a/ModuleScriptLoaderRegistry.o
               WTF::HashTable<blink::Member<blink::ModuleScriptLoader>, blink::Member<blink::ModuleScriptLoader>, WTF::IdentityExtractor, WTF::MemberHash<blink::ModuleScriptLoader>, WTF::HashTraits<blink::Member<blink::ModuleScriptLoader> >, WTF::HashTraits<blink::Member<blink::ModuleScriptLoader> >, blink::HeapAllocator>::Rehash
+    19081 t@0x1fc2318  180     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinkerRegistry.o
               WTF::HashTable<blink::Member<blink::ModuleTreeLinker>, blink::Member<blink::ModuleTreeLinker>, WTF::IdentityExtractor, WTF::MemberHash<blink::ModuleTreeLinker>, WTF::HashTraits<blink::Member<blink::ModuleTreeLinker> >, WTF::HashTraits<blink::Member<blink::ModuleTreeLinker> >, blink::HeapAllocator>::Rehash
+    19259 t@0x1d8749c  178     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               blink::ModuleMap::TraceWrappers const
+    19435 t@0x1b680fc  176     third_party/WebKit/Source/core/libcore_generated.a/V8ScriptRunner.o
               blink::V8ScriptRunner::ReportExceptionForModule
-    19265 t@0x13ea6bc  -170    third_party/WebKit/Source/platform/loader/loader/Resource.o
               WTF::HashTable<blink::WeakMember<blink::ResourceClient>, WTF::KeyValuePair<blink::WeakMember<blink::ResourceClient>, unsigned int>, WTF::KeyValuePairKeyExtractor, WTF::MemberHash<blink::ResourceClient>, WTF::HashMapValueTraits<WTF::HashTraits<blink::WeakMember<blink::ResourceClient> >, WTF::HashTraits<unsigned int> >, WTF::HashTraits<blink::WeakMember<blink::ResourceClient> >, blink::HeapAllocator>::RehashTo
+    19435 t@0x132f5c4  170     third_party/WebKit/Source/platform/platform/V8PerContextData.o
               WTF::HashTable<char const*, WTF::KeyValuePair<char const*, blink::Member<blink::V8PerContextData::Data> >, WTF::KeyValuePairKeyExtractor, WTF::PtrHash<char const>, WTF::HashMapValueTraits<WTF::HashTraits<char const*>, WTF::HashTraits<blink::Member<blink::V8PerContextData::Data> > >, WTF::HashTraits<char const*>, blink::HeapAllocator>::RehashTo
+    19601 t@0x1d8735c  166     third_party/WebKit/Source/core/dom/libdom_2.a/ModuleMap.o
               blink::ModuleMap::Entry::AddClient
+    19767 t@0x1fc23f6  166     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinkerRegistry.o
               blink::ModuleTreeLinkerRegistry::Fetch
+    19933 t@0x1b5b30c  166     third_party/WebKit/Source/core/libcore_generated.a/ScriptModule.o
               blink::ScriptModule::ModuleRequests
+    20093 t@0x1fc166c  160     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               blink::ModuleTreeLinker::Fetch
+    20249 t@0x1b5b0dc  156     third_party/WebKit/Source/core/libcore_generated.a/ScriptModule.o
               blink::ScriptModule::Instantiate
+    20401 t@0x1fc1550  152     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               WTF::HashTable<blink::KURL, blink::KURL, WTF::IdentityExtractor, blink::KURLHash, WTF::HashTraits<blink::KURL>, WTF::HashTraits<blink::KURL>, WTF::PartitionAllocator>::HashTable
+    20547 t@0x1fc2190  146     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               blink::ModuleTreeLinker::Trace
+    20689 t@0x1d999d8  142     third_party/WebKit/Source/core/dom/libdom_3.a/ScriptModuleResolverImpl.o
               WTF::HashTable<blink::ScriptModule, WTF::KeyValuePair<blink::ScriptModule, blink::Member<blink::ModuleScript> >, WTF::KeyValuePairKeyExtractor, blink::ScriptModuleHash, WTF::HashMapValueTraits<WTF::HashTraits<blink::ScriptModule>, WTF::HashTraits<blink::Member<blink::ModuleScript> > >, WTF::HashTraits<blink::ScriptModule>, blink::HeapAllocator>::AllocateTable
+    20825 t@0x1fc2290  136     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinkerRegistry.o
               WTF::HashTable<blink::Member<blink::ModuleTreeLinker>, blink::Member<blink::ModuleTreeLinker>, WTF::IdentityExtractor, WTF::MemberHash<blink::ModuleTreeLinker>, WTF::HashTraits<blink::Member<blink::ModuleTreeLinker> >, WTF::HashTraits<blink::Member<blink::ModuleTreeLinker> >, blink::HeapAllocator>::AllocateTable
+    20961 t@0x1fc1294  136     third_party/WebKit/Source/core/loader/libloader.a/ModuleTreeLinker.o
               blink::HeapAllocator::AllocateVectorBacking<blink::Member<blink::ModuleScript> >
+    21097 t@0x1b67f48  136     third_party/WebKit/Source/core/libcore_generated.a/V8ScriptRunner.o
               blink::V8ScriptRunner::EvaluateModule
+    21233 t@0x2073304  136     third_party/WebKit/Source/core/xml/libxml.a/XMLDocumentParser.o
               blink::XMLDocumentParser::EndElementNs
+    21365 t@0x132f540  132     third_party/WebKit/Source/platform/platform/V8PerContextData.o
               WTF::HashTable<char const*, WTF::KeyValuePair<char const*, blink::Member<blink::V8PerContextData::Data> >, WTF::KeyValuePairKeyExtractor, WTF::PtrHash<char const>, WTF::HashMapValueTraits<WTF::HashTraits<char const*>, WTF::HashTraits<blink::Member<blink::V8PerContextData::Data> > >, WTF::HashTraits<char const*>, blink::HeapAllocator>::AllocateTable
diff_results.txt
81.7 KB View Download
Cc: hirosh...@chromium.org

=== Auto-CCing suspected CL author hiroshige@chromium.org ===

Hi hiroshige@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : hiroshige
  Commit : 7da9cf91983855bf2e5861dbe33d50fc9aca9df0
  Date   : Fri Apr 28 03:16:01 2017
  Subject: Enable module scripts in ScriptLoader

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : resource_sizes
  Metric       : MonochromePublic.apk_Specifics/normalized apk size
  Change       : 0.04% | 73829734.0 -> 73858406.0

Revision             Result               N
chromium@467865      73829734 +- 0.0      6      good
chromium@467866      73858406 +- 0.0      6      bad       <--

To Run This Test
  src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980793199092187968

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5559709374873600


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Components: Blink>HTML>Modules
This looks expected code size increase due to the implementation of a new feature (ES6 module,  Issue 594639 ).
The increase looks like the cumulative increase by a large part of our new implementation (At least the top ~20 of the partial symbol diff (Comment #3) are new functions, implemented by many CLs in  Issue 594639 ).

The increase is reported to be caused by my single CL probably because my CL caused the new code included in the release binary, while the code has been omitted previously because it was unreachable from HTML/JavaScript.
Status: WontFix (was: Assigned)
Makes sense, thanks for the explanation! 
Labels: Performance-Tradeoff
Labels: -binary-size Performance-Size

Sign in to add a comment