Regression: Dock side is seen missing in devtools when opened in second page |
|||||||
Issue descriptionChrome Version: 60.0.3086.0 dev OS: Ubuntu 14.04,windows What steps will reproduce the problem? (1)Launch chrome,Go to NTP and open devtools >> Click on customize and control devtools and observe dock side menu (2)Now open any other page [Hit F1 for help page] >> Right click on page and select Inspect (3)Now observe dock position of devtools >> Click on customize and control devtools menu and observe for dock side menu Expected: In step-3 on inspecting devtools should be opened in previously opened state and dock side menu should be visible on opening 3 dot menu. Actual: Instead devtools opens as separate window and dock side menu is seen missing. This is a regression issue broken in M59. Good Build: 59.0.3065.0 dev Bad Build: 59.0.3066.0 dev
,
May 1 2017
Has bisect per revision result: =============================== https://chromium.googlesource.com/chromium/src/+log/36640ecf2e136c9d8d4dd1a4a25d9175129bb587..7a0e557c4434a838ab29021ae039504fbab4f564 dgozman@: Could you please take a look at this. Thank you!
,
May 2 2017
A related issue, so not sure if it should be reported as a separate bug: when you select "Inspect" from right-click context menu, it should open in the state it was in the last time, but it's not doing that -- for each new tab it's always opening in a separate window first.
,
May 2 2017
Issue 716990 has been merged into this issue.
,
May 2 2017
The offending patch went into M59.
,
May 2 2017
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16fd697aa90b4a2dd30ff37ae51fd52a7c157a98 commit 16fd697aa90b4a2dd30ff37ae51fd52a7c157a98 Author: dgozman <dgozman@chromium.org> Date: Tue May 02 23:33:50 2017 [DevTools] Ensure that tab agent hosts get "page" type If we were to create DevToolsAgentHost for a WebContents before appending that to a tab strip, we wrongly assigned "other" type to it. This happens, for example, when devtools is discovering all agent hosts for newly created web contents. Regressed in crrev.com/7a0e557c4434a838ab29021ae039504fbab4f564 BUG= 717003 Review-Url: https://codereview.chromium.org/2858763002 Cr-Commit-Position: refs/heads/master@{#468815} [modify] https://crrev.com/16fd697aa90b4a2dd30ff37ae51fd52a7c157a98/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/16fd697aa90b4a2dd30ff37ae51fd52a7c157a98/chrome/browser/devtools/devtools_sanity_browsertest.cc
,
May 3 2017
This is working fine on current canary build # 60.0.3088.0 - Win7/64 bit. dgozman@, can you please request merge in to M59 branch as this is working fine on ToT build ?
,
May 3 2017
I'll let it bake one more canary.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e75b1bc9944bfe1a4a1a006e212418243e96abd commit 8e75b1bc9944bfe1a4a1a006e212418243e96abd Author: dgozman <dgozman@chromium.org> Date: Thu May 11 22:52:05 2017 [DevTools] Fix telemetry flakiness based on target type For some unknown reason, crrev.com/468815 caused multiple telemetry tests to timeout. This patch partially reverts that revision, applying another fix to original bug by re-requesting target type on demand. BUG=718952, 717003 Review-Url: https://codereview.chromium.org/2873393002 Cr-Commit-Position: refs/heads/master@{#471102} [modify] https://crrev.com/8e75b1bc9944bfe1a4a1a006e212418243e96abd/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/8e75b1bc9944bfe1a4a1a006e212418243e96abd/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/8e75b1bc9944bfe1a4a1a006e212418243e96abd/content/browser/devtools/render_frame_devtools_agent_host.h
,
May 15 2017
Requesting merge for both patches to M59.
,
May 15 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2017
Please merge your change to M59 branch 3071 before 4:00 PM PT tomorrow, Tuesday (05/16 )so we can pick it for this week beta release. Thank you.
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1cdb1eaec9319ade2c8bfe46b3b8b9ea60bd346 commit d1cdb1eaec9319ade2c8bfe46b3b8b9ea60bd346 Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon May 15 22:36:43 2017 Merge to 3071 "[DevTools] Ensure that tab agent hosts get "page" type" If we were to create DevToolsAgentHost for a WebContents before appending that to a tab strip, we wrongly assigned "other" type to it. This happens, for example, when devtools is discovering all agent hosts for newly created web contents. Regressed in crrev.com/7a0e557c4434a838ab29021ae039504fbab4f564 BUG= 717003 Review-Url: https://codereview.chromium.org/2858763002 Cr-Commit-Position: refs/heads/master@{#468815} (cherry picked from commit 16fd697aa90b4a2dd30ff37ae51fd52a7c157a98) TBR=pfeldman Review-Url: https://codereview.chromium.org/2884103002 . Cr-Commit-Position: refs/branch-heads/3071@{#570} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/d1cdb1eaec9319ade2c8bfe46b3b8b9ea60bd346/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/d1cdb1eaec9319ade2c8bfe46b3b8b9ea60bd346/chrome/browser/devtools/devtools_sanity_browsertest.cc
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cadfb3115e3b20f61e342523a12325a94ded2786 commit cadfb3115e3b20f61e342523a12325a94ded2786 Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon May 15 22:38:39 2017 Merge to 3071 "[DevTools] Fix telemetry flakiness based on target type" For some unknown reason, crrev.com/468815 caused multiple telemetry tests to timeout. This patch partially reverts that revision, applying another fix to original bug by re-requesting target type on demand. BUG=718952, 717003 Review-Url: https://codereview.chromium.org/2873393002 Cr-Commit-Position: refs/heads/master@{#471102} (cherry picked from commit 8e75b1bc9944bfe1a4a1a006e212418243e96abd) TBR=pfeldman Review-Url: https://codereview.chromium.org/2886583002 . Cr-Commit-Position: refs/branch-heads/3071@{#571} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/cadfb3115e3b20f61e342523a12325a94ded2786/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/cadfb3115e3b20f61e342523a12325a94ded2786/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/cadfb3115e3b20f61e342523a12325a94ded2786/content/browser/devtools/render_frame_devtools_agent_host.h
,
May 17 2017
Verified this issue on Mac OS 10.12, Ubuntu 14.04 and Windows-10 using chrome latest beta M59-59.0.3071.61 by following steps mentioned in the original comment, By inspecting the dev tool it displayed in previously opened state and dock side menu is visible on opening 3 dot menu as expected. Hence adding TE-Verified label.
,
May 18 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ajha@chromium.org
, May 1 2017