New issue
Advanced search Search tips

Issue 717001 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

23.kb regression in resource_sizes (MonochromePublic.apk) at 467625:467625

Project Member Reported by estevenson@chromium.org, May 1 2017

Issue description

Caused by: Add month and year to time_format.
https://codereview.chromium.org/2845693002
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=717001

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg0vWgvQkM


Bot(s) for this bug's original alert(s):

Android Builder
Cc: gambard@chromium.org
Owner: gambard@chromium.org

=== Auto-CCing suspected CL author gambard@chromium.org ===

Hi gambard@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : gambard
  Commit : bef90b8dea482e8a4801f9c9c0543ab35ef2fd9f
  Date   : Thu Apr 27 09:23:44 2017
  Subject: Add month and year to time_format.

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : resource_sizes
  Metric       : MonochromePublic.apk_Specifics/normalized apk size
  Change       : 0.03% | 73698560.0 -> 73722148.0

Revision             Result               N
chromium@467624      73698560 +- 0.0      6      good
chromium@467625      73722148 +- 0.0      6      bad       <--

To Run This Test
  src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980796657942058960

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5277468686024704


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
Created this bug before looking at the diff - the bulk of the increase came from adding 6 strings to ui/strings/ui_strings.grd. Probably nothing more to be done here.

Partial diff (via tools/binary_size/diagnose_apk_bloat.py):

   +23,588 bytes MonochromePublic.apk_Specifics normalized apk size
   +21,170 bytes MonochromePublic.apk_InstallSize Estimated installed size
   +20,480 bytes MonochromePublic.apk_InstallSize APK size
   +18,975 bytes MonochromePublic.apk_InstallBreakdown Native resources (l10n) size
   +18,285 bytes MonochromePublic.apk_Uncompressed Native resources (l10n) size
   +18,285 bytes MonochromePublic.apk_Breakdown Native resources (l10n) size
   +10,646 bytes MonochromePublic.apk_TransferSize Transfer size (deflate)
      +476 bytes MonochromePublic.apk_MainLibInfo text
      +336 bytes MonochromePublic.apk_MainLibInfo data
       +96 bytes MonochromePublic.apk_MainLibInfo relocations
       +30 bytes MonochromePublic.apk_Breakdown Package metadata size
       +30 bytes MonochromePublic.apk_InstallBreakdown Package metadata size
Labels: Performance-Tradeoff
Labels: -binary-size Performance-Size

Sign in to add a comment