New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 717000 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Dragged bookmark text should have a background shadow

Project Member Reported by sc00335...@techmahindra.com, May 1 2017

Issue description

Chrome Version: 60.0.3086.0 dev
OS: Ubuntu 14.04

Pre-condition: Make sure your profile is in GTK+ theme

What steps will reproduce the problem?
(1)Launch chrome and add some items to bookmark bar so that chevron icon is seen
(2)Now click on chevron icon and drag bookmarked page/folder to regular page and observe font

Expected: Font of dragged bookmarked item should be properly visible.
Actual: Instead it is seen very light in color.

This is a regression issue broken in M59.

Good Build: 59.0.3036.0 dev
Bad Build: 59.0.3037.0 dev

NOTE: Issue is not applicable to windows
 
Actual_bookmarked name.png
148 KB View Download
Expected_bookmarked page.png
163 KB View Download
Labels: -Needs-Bisect hasbisect
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/caa6a6165d28c3bb499fc0aec9bf391c6bda1578..bc81898122086cf8a510c854583eefee34c1f022

Suspecting  https://codereview.chromium.org/2670623002 from changelog

@thomasanderson: Please confirm whether it is an intended change or bug.

Thanks.
Cc: est...@chromium.org
I'd argue that this is correct behavior.  The drag window has light text on a transparent bg.  It's not very readable on the web page because that has a white background.  But you really care about dragging to another menu (where the text will be visible), not the webpage.

estade@ wdyt?
there are lots of potential drag targets, like the tab strip, the web contents, other desktop applications. I think this is worth fixing somehow. I think there are places where we add shadows around dragged text so it works on both light and dark bg?
Cc: thomasanderson@chromium.org
Labels: -Pri-1 -hasbisect -Type-Bug-Regression -M-60 OS-Chrome OS-Windows Pri-2 Type-Bug
Owner: ----
Status: Available (was: Assigned)
Summary: Dragged bookmark text should have a background shadow (was: Regression: Font of Bookmarked item under chevron icon is not properly seen on dragging it to page)
Ok, that makes sense to me.  I think we do that on Windows when selecting all text in the omnibox and dragging it.

Removing bug-regression and opening this as a broader UI issue.
Project Member

Comment 5 by sheriffbot@chromium.org, May 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment