New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716977 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 646326
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

SOM groups large numbers of unrelated tests together

Project Member Reported by suzyh@chromium.org, May 1 2017

Issue description

On Sheriff-o-Matic, under "consistent failures" for instance, are items described as e.g. "webkit_tests failing on ... " and which cover a large number of tests and bugs. See example screenshot attached. It's difficult to know where to start to take action on these, since it seems to be a collection of unrelated flakes or failures.

I had a feeling this had already been raised as an issue but can't find a suitable bug, except perhaps  issue 692876 .
 
Screenshot from 2017-05-01 16:28:28.png
106 KB View Download
Could we get Sheriff-o-Matic to understand the structuring of webkit tests? It looks like SOM is already able to understand the individual test failing?

Initially maybe just using directory level grouping is a good start and then extending it to do some type of "longest common prefix" type grouping (maybe with some type of minimum depth?).

You'll probably want some type of special handling for virtual prefix too.

For example;

Grouping these together makes sense;
 - virtual/gpu/fast/canvas/canvas-clip-rule.html
 - virtual/gpu/fast/canvas/canvas-path-context-clip.html

Grouping these together make sense;
 - virtual/gpu/fast/canvas/canvas-clip-rule.html
 - gpu/fast/canvas/canvas-clip-rule.html

Grouping these together *doesn't* really make sense;
 - animations/missing-from-to.html
 - nfc/mock-nfc.html

It might or might not make sense to group things under css3/.* - A problem affecting css3/motion-path and css3/calc could be related or they might not...

---

An alternative might just let the user specify a regex to use for grouping stuff together? Maybe even when you merge two failing webkit_tests together you could calculate the regex automatically using the "longest common prefix" bit?
Cc: tansell@chromium.org
If SOM needs some more information or annotations from the output of buildbots to make this style of thing work, please do ask and I'll see what we can do..

Comment 4 Deleted

Cc: zhangtiff@chromium.org seanmccullough@chromium.org
Labels: -Pri-3 Milestone-UX Pri-2
Status: Available (was: Untriaged)
Thanks for filing this bug! I think we definitely need to figure out something to make webkit_tests handled better. 

I like the idea of maybe using some sort of directory level grouping as a simple heuristic. I think user regexes is maybe adding a bit more mental overhead to the user than we would want for Sheriff-o-Matic, so I'd like to avoid that approach if possible. But I think we should be able to come up with some sort of system that at least makes the groups a bit more distinct than they are now. 
Mergedinto: 664207
Status: Duplicate (was: Available)
Mergedinto: -664207 646326

Sign in to add a comment