IME settings menu depends on chrome://settings-frame |
||||||||
Issue descriptionSteps To Reproduce: 1. Open US Keyboard settings page from settings (Lauguages and input > Input method > US keyboard > gear icon). 2. Click "Edit Dictionary Entries" Expected Result: New "Custom spelling" settings UI should open Actual Result: Old UI chrome://settings-fram/editDictionary opens chrome://settings-frame is going away in M-60, and we should not rely on it. shuchen@ could you take a look?
,
May 6 2017
This should be fixed ASAP since MD Settings is launching in M59. It should instead use chrome://settings/editDictionary
,
May 6 2017
Sorry for late response. I will fix this in early next week.
,
May 9 2017
CL pending on approval: https://chrome-internal-review.googlesource.com/c/371508/
,
May 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/9280b766d195aeaa920d5a31ae0898e6344bdd8b commit 9280b766d195aeaa920d5a31ae0898e6344bdd8b Author: Shu Chen <shuchen@google.com> Date: Sun May 14 21:51:25 2017
,
May 17 2017
,
May 18 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 22 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 23 2017
The fix merge cl https://chrome-internal-review.googlesource.com/c/378348/ requires approval.
,
May 26 2017
Can someone help to approve https://chrome-internal-review.googlesource.com/c/378348/?
,
May 26 2017
Approved. Thank you for the fix.
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/f39f8aa965d0ceda2fa0474829ad5e57f43c09c8 commit f39f8aa965d0ceda2fa0474829ad5e57f43c09c8 Author: Shu Chen <shuchen@google.com> Date: Fri May 26 05:40:25 2017
,
May 26 2017
,
May 26 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by oka@chromium.org
, May 1 2017