New issue
Advanced search Search tips

Issue 716963 link

Starred by 2 users
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 257235



Sign in to add a comment

Web Animations: Use PlaybackDirection enum in AnimationEffectTiming.idl

Project Member Reported by ericwilligers@chromium.org, May 1 2017 
AnimationEffectTiming.idl and AnimationEffectTimingReadOnly.idl
should have (instead of DOMString)
attribute PlaybackDirection direction;

We are already defining and using the enum in 
AnimationEffectTimingProperties.idl
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5604209f8fc4438c7e141696089c3d2985928b

commit 9c5604209f8fc4438c7e141696089c3d2985928b
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon May 01 06:21:27 2017

Web Animations: Use PlaybackDirection enum in AnimationEffectTiming.idl

AnimationEffectTiming.idl and AnimationEffectTimingReadOnly.idl
now use
attribute PlaybackDirection direction;
for consistency with the spec.

https://w3c.github.io/web-animations/#the-animationeffecttiming-interface
https://w3c.github.io/web-animations/#the-animationeffecttimingreadonly-interface

BUG= 716963 

Review-Url: https://codereview.chromium.org/2856503002
Cr-Commit-Position: refs/heads/master@{#468295}

[modify] https://crrev.com/9c5604209f8fc4438c7e141696089c3d2985928b/third_party/WebKit/Source/core/animation/AnimationEffectTiming.idl
[modify] https://crrev.com/9c5604209f8fc4438c7e141696089c3d2985928b/third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.idl

Comment 2 by ericwilligers@chromium.org, May 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment