New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 716956 link

Starred by 1 user
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocked on:
issue 717323


Sign in to add a comment

WebShareTargetPickerView interface refactor

Project Member Reported by mgiuca@chromium.org, May 1 2017 
A few small things to change about the WebShareTargetPickerView class (refactor).

- WebShareTargetPickerView callback should be const &.
- WebShareTargetPickerView callback should be GURL, not std::string.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/928d141051d4bf9b8ae82a708e914470f5787b54

commit 928d141051d4bf9b8ae82a708e914470f5787b54
Author: ortuno <ortuno@chromium.org>
Date: Tue May 02 00:09:05 2017

webshare: Small refactor of WebShare (OnceCallback, const&, and alias)

1. Uses OnceCallback instead of Callback.
2. Changes the close callback to use a const& to avoid copying the string.
3. Adds an alias for base::OnceCallback<void(const base::Optional<std::string>&)>:
   WebShareTargetPickerCallback.

BUG= 716956 

Review-Url: https://codereview.chromium.org/2849143002
Cr-Commit-Position: refs/heads/master@{#468498}

[modify] https://crrev.com/928d141051d4bf9b8ae82a708e914470f5787b54/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/928d141051d4bf9b8ae82a708e914470f5787b54/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
[modify] https://crrev.com/928d141051d4bf9b8ae82a708e914470f5787b54/chrome/browser/ui/views/webshare/webshare_target_picker_view.h
[modify] https://crrev.com/928d141051d4bf9b8ae82a708e914470f5787b54/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc
[modify] https://crrev.com/928d141051d4bf9b8ae82a708e914470f5787b54/chrome/browser/webshare/share_service_impl.cc
[modify] https://crrev.com/928d141051d4bf9b8ae82a708e914470f5787b54/chrome/browser/webshare/share_service_impl.h
[modify] https://crrev.com/928d141051d4bf9b8ae82a708e914470f5787b54/chrome/browser/webshare/share_service_impl_unittest.cc

Comment 2 by mgiuca@chromium.org, May 2 2017

Status: Fixed (was: Assigned)

Comment 3 by mgiuca@chromium.org, May 2 2017

Blockedon: 717323

Comment 4 by mgiuca@chromium.org, May 2 2017

Status: Started (was: Fixed)
Ah not quite done yet (the GURL one):  Issue 717323

Comment 5 by ortuno@chromium.org, Jul 7 2017

Status: Fixed (was: Started)
Fixed by  Issue 717323
►

Sign in to add a comment