"DeviceDescriptionServiceTest.TestCleanUpCacheEntries" is flaky |
||||||
Issue description"DeviceDescriptionServiceTest.TestCleanUpCacheEntries" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjREZXZpY2VEZXNjcmlwdGlvblNlcnZpY2VUZXN0LlRlc3RDbGVhblVwQ2FjaGVFbnRyaWVzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 30 2017
,
May 1 2017
Selectively disabling test in https://codereview.chromium.org/2853723002 Adding Blink>PresentationAPI as per //src/chrome/browser/media/router/OWNERS
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e578e69e97678337cd294fafc9d051b73c61c7f2 commit e578e69e97678337cd294fafc9d051b73c61c7f2 Author: thestig <thestig@chromium.org> Date: Mon May 01 01:39:01 2017 Disable 2 flaky tests. - NSS/ClientCertStoreTest/CertAuthorityFiltering - DeviceDescriptionServiceTest.TestCleanUpCacheEntries BUG= 716730 , 716810 TBR=mattm@chromium.org,zhaobin@chromium.org Review-Url: https://codereview.chromium.org/2850083002 Cr-Commit-Position: refs/heads/master@{#468267} [modify] https://crrev.com/e578e69e97678337cd294fafc9d051b73c61c7f2/chrome/browser/media/router/discovery/dial/device_description_service_unittest.cc [modify] https://crrev.com/e578e69e97678337cd294fafc9d051b73c61c7f2/net/ssl/client_cert_store_unittest-inl.h
,
May 1 2017
In that case, cancelling commit of my patch ^.^
,
May 1 2017
Detected 19 new flakes for test/step "DeviceDescriptionServiceTest.TestCleanUpCacheEntries". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjREZXZpY2VEZXNjcmlwdGlvblNlcnZpY2VUZXN0LlRlc3RDbGVhblVwQ2FjaGVFbnRyaWVzDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
May 1 2017
Findit analyzed this flake and suspects https://codereview.chromium.org/2701633002/ as the culprit according to analysis https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKCAWNocm9taXVtLm1hYy9NYWMxMC4xMCBUZXN0cy8xNzM3NS91bml0X3Rlc3RzIG9uIE1hYy0xMC4xMC9SR1YyYVdObFJHVnpZM0pwY0hScGIyNVRaWEoyYVdObFZHVnpkQzVVWlhOMFEyeGxZVzVWY0VOaFkyaGxSVzUwY21sbGN3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Can someone please help confirm? Thanks, Jeff on behalf of Findit team
,
May 1 2017
#7: Yes, that's the CL identified in #2, which added the test. chromium-try-flakes is only reporting flakes from before the test was disabled in #4, so re-removing sheriff label.
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68a2976a94249c55ad3b0bacee12bf047cacfc9 commit b68a2976a94249c55ad3b0bacee12bf047cacfc9 Author: zhaobin <zhaobin@chromium.org> Date: Wed May 03 00:53:52 2017 [Media Router] Fix unit test "DeviceDescriptionServiceTest.TestCleanUpCacheEntries" cache_entry.expire_time = base::Time::Now(); does not guarantee the cache entry is expired. BUG= 716810 Review-Url: https://codereview.chromium.org/2857763002 Cr-Commit-Position: refs/heads/master@{#468846} [modify] https://crrev.com/b68a2976a94249c55ad3b0bacee12bf047cacfc9/chrome/browser/media/router/discovery/dial/device_description_service_unittest.cc
,
May 3 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by thestig@chromium.org
, Apr 30 2017