Dialogs should be laid out better on small screens |
||||
Issue descriptionHaving headers and footers on dialogs makes the scrollable content painfully difficult to interact with. As per go/snowflake-dialogs, we should make the headers scroll off when the dialog is below some size threshold. Footers might be required for legal content and should probably stay visible.
,
May 3 2017
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label. All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 3 2017
,
May 23 2017
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b270ad84689e4a41259edbecdebcce2ecb8772b commit 7b270ad84689e4a41259edbecdebcce2ecb8772b Author: tedchoc <tedchoc@chromium.org> Date: Tue May 23 21:29:51 2017 Add better handling for very, very small promo dialogs. Previously when there was no illustration, the header was unconditionally moved outside of the scrollable content. This makes for a better UI overall, but on small screens it can make the content impossible to interact with. Now, we move the header in an out of the scrollable region based on the height of the scroll container. If the height is too small, then the header is pushed into the scrollable container. BUG= 716808 Review-Url: https://codereview.chromium.org/2902793002 Cr-Commit-Position: refs/heads/master@{#474062} [modify] https://crrev.com/7b270ad84689e4a41259edbecdebcce2ecb8772b/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/7b270ad84689e4a41259edbecdebcce2ecb8772b/chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java [modify] https://crrev.com/7b270ad84689e4a41259edbecdebcce2ecb8772b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java
,
May 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dfalcant...@chromium.org
, May 2 2017