New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716797 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Stylimations-OKR-2017-Q2


Sign in to add a comment

Elements position after chrome update

Reported by fernando...@gmail.com, Apr 29 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Steps to reproduce the problem:
see at 

http://codeforeveryone.esy.es/photographer/site/

or

http://aerorock.primeirocodigo.com.br/home

What is the expected behavior?

What went wrong?
elements position error only in google chrome Version 58*

Did this work before? Yes 57.0.2987.133

Chrome version: 58.0.3029.81  Channel: stable
OS Version: 10.0
Flash Version:
 
chrome.jpg
39.2 KB View Download
Labels: Prestable-58.0.3029.81 Needs-Triage-M58
Cc: jmukthavaram@chromium.org
Labels: -Pri-2 -Needs-Triage-M58 hasbisect-per-revision M-58 OS-Linux OS-Mac Pri-1
Owner: r...@opera.com
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on windows 7, Mac 10.12.4,Linux Ubuntu 14.04 with Chrome stable version-58.0.3029.96 and Canary-60.0.3087.0.
Manual Bisect:
-------------
Good-58.0.3025.0-Revision-453134
Bad-58.0.3026.0 -Revision-453454

Per revision Bisect Tool Info:
------------------------------
You are probably looking for a change made after 453429 (known good), but no later than 453430 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/687ef074d2b0996276993f55547873dd8e9e4246..21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9

Possible suspect:
-----------------
https://chromium.googlesource.com/chromium/src/+/21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9

Rune@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Thanks.!
Labels: Needs-triage-Mobile
What is this

Comment 5 by r...@opera.com, May 4 2017

Components: -UI Blink>CSS
Status: Started (was: Assigned)
Reduced test-case attached.
textalign.html
208 bytes View Download

Comment 7 by suzyh@chromium.org, May 5 2017

Labels: Regressed-58
Labels: Update-Weekly
Project Member

Comment 9 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11

commit be16e0bd842e5f7c1d62211f95e04ba41d2c3e11
Author: rune <rune@opera.com>
Date: Fri May 05 07:11:12 2017

Disable inheritance propagation for text-align.

The text-align property has an internal value -webkit-match-parent with
a dependency on the parent computed style used in the UA sheet for LI,
which means the independent inheritance optimization won't work.

R=ktyliu@chromium.org,nainar@chromium.org
BUG= 716797 

Review-Url: https://codereview.chromium.org/2860743004
Cr-Commit-Position: refs/heads/master@{#469609}

[modify] https://crrev.com/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt
[modify] https://crrev.com/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html
[add] https://crrev.com/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11/third_party/WebKit/LayoutTests/fast/css/text-align-inherit-webkit-match-parent-expected.html
[add] https://crrev.com/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11/third_party/WebKit/LayoutTests/fast/css/text-align-inherit-webkit-match-parent.html
[modify] https://crrev.com/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Comment 10 by r...@opera.com, May 5 2017

Status: Fixed (was: Started)

Comment 11 by r...@opera.com, May 8 2017

Labels: Merge-Request-59
Project Member

Comment 12 by sheriffbot@chromium.org, May 8 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, May 8 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762028d6306d265b180db30cce1bda522d0dd957

commit 762028d6306d265b180db30cce1bda522d0dd957
Author: Rune Lillesveen <rune@opera.com>
Date: Mon May 08 21:46:02 2017

Disable inheritance propagation for text-align.

The text-align property has an internal value -webkit-match-parent with
a dependency on the parent computed style used in the UA sheet for LI,
which means the independent inheritance optimization won't work.

R=ktyliu@chromium.org,nainar@chromium.org
BUG= 716797 

Review-Url: https://codereview.chromium.org/2860743004
Cr-Commit-Position: refs/heads/master@{#469609}
(cherry picked from commit be16e0bd842e5f7c1d62211f95e04ba41d2c3e11)

Review-Url: https://codereview.chromium.org/2867223002 .
Cr-Commit-Position: refs/branch-heads/3071@{#466}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/762028d6306d265b180db30cce1bda522d0dd957/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt
[modify] https://crrev.com/762028d6306d265b180db30cce1bda522d0dd957/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html
[add] https://crrev.com/762028d6306d265b180db30cce1bda522d0dd957/third_party/WebKit/LayoutTests/fast/css/text-align-inherit-webkit-match-parent-expected.html
[add] https://crrev.com/762028d6306d265b180db30cce1bda522d0dd957/third_party/WebKit/LayoutTests/fast/css/text-align-inherit-webkit-match-parent.html
[modify] https://crrev.com/762028d6306d265b180db30cce1bda522d0dd957/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/762028d6306d265b180db30cce1bda522d0dd957/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Labels: TE-Verified-59.0.3071.47 TE-Verified-59
Verified this issue on Win 10, Mac 10.12.4, Ubuntu 14.04 using chrome latest beta M59 #59.0.3071.47 by following steps mentioned in the original comment. 

Observed the icons are no more overlapped with the text on the Webpage . Hence adding the TE- Verified label

Please refer the screen cast
May 10 2017 11-37 AM.webm
2.7 MB View Download

Comment 15 by r...@opera.com, May 26 2017

Cc: r...@opera.com hdodda@chromium.org
 Issue 726118  has been merged into this issue.

Sign in to add a comment