New issue
Advanced search Search tips

Issue 716794 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 629964



Sign in to add a comment

JavaScriptDialogExtensionsClient calls need to be made

Project Member Reported by a...@chromium.org, Apr 29 2017

Issue description

They're not currently for new-style dialogs.
 

Comment 1 by a...@chromium.org, Apr 29 2017

Blocking: 629964

Comment 2 by a...@chromium.org, May 1 2017

Status: WontFix (was: Untriaged)
No, they don't.

The JavaScriptDialogTabHelper only handles dialogs for tabs in a browser window.

The reference counting facilitated by the JavaScriptDialogExtensionsClient is for extension background/event pages, which are never tabs in a browser window.


Sign in to add a comment