Chrome 60 (Canary) on Mac with new Mac native notifications, buttons added are not triggering their onclick listener
Reported by
ryanjold...@gmail.com,
Apr 29 2017
|
|||||||||||||||
Issue descriptionChrome Version : 60.0.3084.0 OS Version: OS X 10.12.4 What steps will reproduce the problem? 1. Show a notification using the chrome.notifications API with a custom button 2. On the Mac notification that shows, click "More", then click on the button you added in step 1 What is the expected result? The onclick callback for that button would be fired What happens instead of that? The onclick listener for the notification is fired (thus triggering the wrong action) UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3084.0 Safari/537.36
,
May 2 2017
ryanjoldenburg@ Could you please help us with the sample html test case and expected behavior of this issue for further triage from TE-End. Thank You...
,
May 2 2017
See the attached extension to reproduce the bug. Loading the extension will show a notification. Click on the button labeled "Button". Notice that pre-Canary 60 on Mac, it prints onButtonClicked to the console. With the new Canary, it prints onClicked instead.
,
May 2 2017
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2017
Thank you for your report, we'll look into this!
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5d0ff4df4be89a8ec26ab26d7d468a54c294616 commit e5d0ff4df4be89a8ec26ab26d7d468a54c294616 Author: miguelg <miguelg@chromium.org> Date: Wed May 03 00:31:04 2017 Consider Button clicks for extension notifications BUG= 716782 Review-Url: https://codereview.chromium.org/2855983002 Cr-Commit-Position: refs/heads/master@{#468836} [modify] https://crrev.com/e5d0ff4df4be89a8ec26ab26d7d468a54c294616/chrome/browser/notifications/non_persistent_notification_handler.cc
,
May 3 2017
Requesting merge for M59. Thanks for the quick fix Miguel! :)
,
May 3 2017
,
May 3 2017
NP, it was an oversight on my part after all :) This made it into canary 60.0.3088.0 and I have verified it works with both an extension and a chrome app. We will merge it in the current Beta release as well.
,
May 4 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe1040fe4e90f8d9f4a81ef49c5047a5386a5ae commit 6fe1040fe4e90f8d9f4a81ef49c5047a5386a5ae Author: Miguel Garcia <miguelg@chromium.org> Date: Thu May 04 09:09:43 2017 Consider Button clicks for extension notifications BUG= 716782 Review-Url: https://codereview.chromium.org/2855983002 Cr-Commit-Position: refs/heads/master@{#468836} (cherry picked from commit e5d0ff4df4be89a8ec26ab26d7d468a54c294616) Review-Url: https://codereview.chromium.org/2859153002 . Cr-Commit-Position: refs/branch-heads/3071@{#395} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/6fe1040fe4e90f8d9f4a81ef49c5047a5386a5ae/chrome/browser/notifications/non_persistent_notification_handler.cc
,
May 4 2017
,
May 10 2017
Tested the issue on Mac-10.12.4 using chrome version 59.0.3071.47 with the steps mentioned in comment#0 and 3. Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screenshot for the same. Thanks!!
,
May 10 2017
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by kochi@chromium.org
, May 1 2017