The flakiness dashboard shows this test sporadically timing out. Disabling in https://codereview.chromium.org/2849073003

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78552aab8b749f33cd8176a977bdff4fa7d5de50

commit 78552aab8b749f33cd8176a977bdff4fa7d5de50
Author: suzyh <suzyh@chromium.org>
Date: Mon May 01 05:02:13 2017

Disable flaky ExperimentalAppWindowApiTest.SetIcon

TBR=benwells@chromium.org
BUG=716726

Review-Url: https://codereview.chromium.org/2849073003
Cr-Commit-Position: refs/heads/master@{#468285}

[modify] https://crrev.com/78552aab8b749f33cd8176a977bdff4fa7d5de50/extensions/browser/api/app_window/app_window_apitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfe887bdaf1ea9fb0b3a7566dbdde620c869d42c

commit dfe887bdaf1ea9fb0b3a7566dbdde620c869d42c
Author: suzyh <suzyh@chromium.org>
Date: Mon May 01 05:29:57 2017

Revert of Disable flaky ExperimentalAppWindowApiTest.SetIcon (patchset #1 id:1 of https://codereview.chromium.org/2849073003/ )

Reason for revert:
Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841

Original issue's description:
> Disable flaky ExperimentalAppWindowApiTest.SetIcon
>
> TBR=benwells@chromium.org
> BUG=716726
>
> Review-Url: https://codereview.chromium.org/2849073003
> Cr-Commit-Position: refs/heads/master@{#468285}
> Committed: https://chromium.googlesource.com/chromium/src/+/78552aab8b749f33cd8176a977bdff4fa7d5de50

TBR=benwells@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716726

Review-Url: https://codereview.chromium.org/2855563002
Cr-Commit-Position: refs/heads/master@{#468289}

[modify] https://crrev.com/dfe887bdaf1ea9fb0b3a7566dbdde620c869d42c/extensions/browser/api/app_window/app_window_apitest.cc

This test and the API it is testing should be deleted.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1853a2e624d2e0f62729eab082c8a1deae1a16e7

commit 1853a2e624d2e0f62729eab082c8a1deae1a16e7
Author: suzyh <suzyh@chromium.org>
Date: Mon May 01 07:09:44 2017

Reland of Disable flaky ExperimentalAppWindowApiTest.SetIcon (patchset #1 id:1 of https://codereview.chromium.org/2855563002/ )

Reason for revert:
Build failure causing original revert seems to have been a flake.

Original issue's description:
> Revert of Disable flaky ExperimentalAppWindowApiTest.SetIcon (patchset #1 id:1 of https://codereview.chromium.org/2849073003/ )
>
> Reason for revert:
> Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841
>
> Original issue's description:
> > Disable flaky ExperimentalAppWindowApiTest.SetIcon
> >
> > TBR=benwells@chromium.org
> > BUG=716726
> >
> > Review-Url: https://codereview.chromium.org/2849073003
> > Cr-Commit-Position: refs/heads/master@{#468285}
> > Committed: https://chromium.googlesource.com/chromium/src/+/78552aab8b749f33cd8176a977bdff4fa7d5de50
>
> TBR=benwells@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=716726
>
> Review-Url: https://codereview.chromium.org/2855563002
> Cr-Commit-Position: refs/heads/master@{#468289}
> Committed: https://chromium.googlesource.com/chromium/src/+/dfe887bdaf1ea9fb0b3a7566dbdde620c869d42c

TBR=benwells@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716726

Review-Url: https://codereview.chromium.org/2856523003
Cr-Commit-Position: refs/heads/master@{#468303}

[modify] https://crrev.com/1853a2e624d2e0f62729eab082c8a1deae1a16e7/extensions/browser/api/app_window/app_window_apitest.cc

Steven - the setIcon api isn't documented and is commented in the IDL as experimental. Since the test has started failing, do you mind if I just remove the API? I think if it is still experimental it's never going to be released properly.

We do have internal code that uses this API, including the filemanager video player:

https://cs.corp.google.com/search/?q=window.setIcon+lang:%5Ejavascript$&m=100&det=none&sort=1&type=cs

+yoshiki@

I suspect that the breakage might be related to mus+ash work? Here is the implementation:

https://cs.chromium.org/chromium/src/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc?type=cs&q=SetIconFunction&l=304

Unfortunately only 1/5 failed tryjobs is still accessible, and the logdog output doesn't show any indication of the failure. This seems a little bit iff evidence-wise to disable the test :(

What does this API do?  Is it for shelf/panels?

If it's for icons in the window frame I doubt mustash refactoring would have touched it.

IIRC it allows an app to change its shelf icon. I think that it is primarily (maybe exclusively?) used for panels.

Given the lack of failure details I don't have any information with which to make a better guess as to what the causes is.

There are only 5 failures ever, 4 on the same day. I suspect this may be a victim of false flake identification? I would suggest reverting the disable until / unless this test flakes again.

If the test only broke in mash_browser_tests and not browser_tests, it should probably just be disabled for mash_browser_tests. There is a filter file at testing/buildbot/filters/mojo.fyi.browser_tests.filter, or you can early return if chromeos::GetAshConfig() == ash::Config::MASH.

punting to stevenjb to reland / updated the test and deal with any more flakes, if they happen

Did anyone grab the logs of the failure before they were deleted?

Lowering the priority since the test is currently disabled. I'll get to this eventually but it's not high on my list.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f212960eb19b495d895733c52d825b42ea3bd5

commit 19f212960eb19b495d895733c52d825b42ea3bd5
Author: jonross <jonross@chromium.org>
Date: Wed May 10 14:15:35 2017

Disable ExperimentalAppWindowApiTest.SetIcon on mash_browser_tests

Remove flaky test from the whitelist for mash_browser_tests so that it can be
re-enabled on the main test suite.

TBR=sky@chromium.org
TEST=ExperimentalAppWindowApiTest.SetIcon
BUG=716726

Review-Url: https://codereview.chromium.org/2870203004
Cr-Commit-Position: refs/heads/master@{#470558}

[modify] https://crrev.com/19f212960eb19b495d895733c52d825b42ea3bd5/testing/buildbot/filters/mash.browser_tests.filter

I've disabled this test on mash_browser_tests, since we believe it is only flaky there.

->benwells@ to triage. We should decide whether we want to keep / maintain this or not.