New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 716713 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Container-overflow in SkSL::Compiler::addDefinitions

Project Member Reported by ClusterFuzz, Apr 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5143412983726080

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Container-overflow READ 4
Crash Address: 0x61000006be40
Crash State:
  SkSL::Compiler::addDefinitions
  SkSL::Compiler::scanCFG
  SkSL::Compiler::internalConvertProgram
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_media&range=468030:468089

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5143412983726080


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 29 2017

Labels: M-60
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 29 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 29 2017

Labels: Pri-1
Components: Internals>Skia
Owner: ethannicholas@chromium.org
Status: Assigned (was: Untriaged)
Suspecting https://chromium.googlesource.com/skia/+/fe53e5828fd31326cdc4594ca06435eb0af50afe%5E%21/#F0

ethannicholas@: Can you please take a look or reassign as appropriate? Thanks.
ethannicholas: Friendly ping as part of the security fixit week.
Status: Fixed (was: Assigned)
I believe this will be fixed by https://skia-review.googlesource.com/c/15383/.
Project Member

Comment 7 by ClusterFuzz, May 6 2017

ClusterFuzz has detected this issue as fixed in range 469656:469727.

Detailed report: https://clusterfuzz.com/testcase?key=5143412983726080

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Container-overflow READ 4
Crash Address: 0x61000006be40
Crash State:
  SkSL::Compiler::addDefinitions
  SkSL::Compiler::scanCFG
  SkSL::Compiler::internalConvertProgram
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_media&range=468030:468089
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_media&range=469656:469727

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5143412983726080


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by sheriffbot@chromium.org, May 6 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-unpaid reward-1500
Nice one attekett! The panel decided to award $1,000 for this, plus the $500 clusterfuzz bonus.

However, they would consider raising the reward if you could demonstrate how it could be used.

Labels: -reward-unpaid reward-inprocess
Labels: -ReleaseBlock-Beta
Project Member

Comment 13 by sheriffbot@chromium.org, Aug 12 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment