New issue
Advanced search Search tips

Issue 716699 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: May 2017
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[Remoting iOS] Issues with the renderer configurations

Project Member Reported by yuweih@chromium.org, Apr 29 2017 
A bug for tracking fixes on the renderer configurations.

1. Screen tearing issue: the default GLKViewController render loop will swap buffer when the image is still being rendered.

2. Wrong aspect ratio: The resolution was hardcoded.
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807d153f2330e11c8f6f6590ec0eab737c39dffe

commit 807d153f2330e11c8f6f6590ec0eab737c39dffe
Author: yuweih <yuweih@chromium.org>
Date: Mon May 01 21:35:32 2017

[Remoting iOS] Fix screen tearing and screen dimensions

This CL:
1. Fixes the screen tearing issue by getting rid of the GLKViewController,
   which runs its rendering loops and swaps buffers in unexpected moment. The
   GL view will now do on-demand buffer swapping, similar to how the Android
   client works.
2. Passes GL view dimensions to the renderer to fix the screen aspect issues.

BUG= 716699 

Review-Url: https://codereview.chromium.org/2848143002
Cr-Commit-Position: refs/heads/master@{#468418}

[modify] https://crrev.com/807d153f2330e11c8f6f6590ec0eab737c39dffe/remoting/client/ios/app/host_view_controller.h
[modify] https://crrev.com/807d153f2330e11c8f6f6590ec0eab737c39dffe/remoting/client/ios/app/host_view_controller.mm
[modify] https://crrev.com/807d153f2330e11c8f6f6590ec0eab737c39dffe/remoting/client/ios/display/gl_display_handler.h
[modify] https://crrev.com/807d153f2330e11c8f6f6590ec0eab737c39dffe/remoting/client/ios/display/gl_display_handler.mm

Comment 2 by yuweih@chromium.org, May 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment