New issue
Advanced search Search tips

Issue 716663 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Widevine browser_tests fail to start the license server

Project Member Reported by jrumm...@chromium.org, Apr 28 2017

Issue description

Running the Widevine browser_tests locally (e.g. ./out/Debug/browser_tests --gtest_filter=MSE_Widevine*.*) generates the following:

[17585:17585:0428/142737.563929:FATAL:thread_restrictions.cc(38)] Check failed: false. Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.
#0 0x7f16bf7bc30b base::debug::StackTrace::StackTrace()
#1 0x7f16bf7bb00c base::debug::StackTrace::StackTrace()
#2 0x7f16bf82e503 logging::LogMessage::~LogMessage()
#3 0x7f16bf9adec7 base::ThreadRestrictions::AssertIOAllowed()
#4 0x7f16bf8055e4 base::DirectoryExists()
#5 0x000004068dd8 GetPyProtoPath()
#6 0x000000f0e522 WVTestLicenseServerConfig::GetServerCommandLine()
#7 0x000000eb45ee TestLicenseServer::Start()
#8 0x000000e9bf59 chrome::EncryptedMediaTestBase::StartLicenseServerIfNeeded()
#9 0x000000e9bd35 chrome::EncryptedMediaTestBase::RunEncryptedMediaTestPage()
#10 0x000000e97d23 chrome::EncryptedMediaTestBase::RunEncryptedMediaTest()
#11 0x000000e9a225 chrome::EncryptedMediaTestBase::RunSimpleEncryptedMediaTest()
#12 0x000000e95cc3 chrome::EncryptedMediaTest::TestSimplePlayback()
#13 0x000000e93902 chrome::EncryptedMediaTest_Playback_VP9Video_WebM_Fullsample_Test::RunTestOnMainThread()
#14 0x000003f0ccba content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()

It appears that a recent change (https://codereview.chromium.org/2832153003) has disabled browser_tests from doing IO while running.

Fix is to use base::ThreadRestrictions::ScopedAllowIO around starting the license server.
 
Interesting. Presubmit checks disallow the use of ScopedAllowIO.
Project Member

Comment 2 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f8b2079c4dc288b432200cad216f7c81efc44a

commit 90f8b2079c4dc288b432200cad216f7c81efc44a
Author: jrummell <jrummell@chromium.org>
Date: Fri May 05 17:21:39 2017

Enable IO when starting the license server

Due to recent changes to browser_tests, IO is not allowed. However the license
server is just a Python script, so IO is necessary to start it.

BUG= 716663 
TEST=affected browser_tests run locally
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2857323002
Cr-Commit-Position: refs/heads/master@{#469698}

[modify] https://crrev.com/90f8b2079c4dc288b432200cad216f7c81efc44a/chrome/browser/media/encrypted_media_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment