Chinese letters get printed in Bold when Link device is connected to an external monitor |
|||||||
Issue descriptionChrome Version: 59.0.3071.30 OS: 9460.14.0 Device --> Link What steps will reproduce the problem? Connect the Link Device to an external monitor. (1) Launch Chrome. Add Chinese language by selecting Pinyin input method in Settings. (2) Change the IME to Pinyin (3) Start typing "gao gao" and select 1 from the drop down to select the first entry in the drop-down box. What is the expected result? Chinese characters should be printed in regular font. What happens instead? Chinese characters are printed in bold font. Please find the attached screen shot.
,
Apr 29 2017
Not a regression issue as this is seen on M58 Build # 9334.58.0/58.0.3029.89 as well.
,
May 1 2017
Over to UI>GFX. The chrome UI does not use Blink to render text.
,
May 5 2017
,
May 5 2017
I don't have a ChromeOS device handy. Can you confirm that the issue only appears when connected to an external monitor?
,
May 8 2017
Tested this on a Chromebook Pixel (58.0.3029.89 beta) and a HP LP3065 at 1280x800. I can confirm that it only happens on the external monitor. The issue appears to be with how the font is rendered at that size, however. It's not specific to the omnibox. If you look at the attached screenshot, the same issue exhibits in a web text field. Back to UI>GFX to see if someone there knows where to route this.
,
May 12 2017
Oshima, any idea who should own this?
,
May 16 2017
malaykeshav@ can you test if disabling subpixel positioning fixes this? https://cs.chromium.org/chromium/src/ui/gfx/font_render_params_linux.cc?rcl=3b7bbdee66154192e114f69457e411fcce7333a9&l=282
,
May 18 2017
Trying this out on samus with an external display set to 1280x800 I did not notice any bold effect. Attaching screenshot. @pucchakayala Can you confirm the external monitor that was being used and the resolution it was set at.
,
May 18 2017
Attaching screenshot again
,
May 18 2017
Dont have the cable to connect my link to an external display atm. Will post an update.
,
May 18 2017
Checking, will update the issue soon.
,
May 18 2017
This happens only when Link device is connected to an external monitor. Still seeing the issue on latest Beta build # 9460.42.0/59.0.3071.57 External Monitor --> HP LP2465 Resolution --> 1920*1200 [Best]
,
May 18 2017
#13 Thanks! #8 Trying out with link and external monitor does show this issue and disabling the subpixel positioning fixes it. Attaching screenshots
,
May 19 2017
Thanks. We can disable it when we enable scalable view.
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3cf0f7886f3174453e3101bb7d7c3057e761c33 commit e3cf0f7886f3174453e3101bb7d7c3057e761c33 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Apr 24 23:21:18 2018 Disable subpixel positioning on chrome os Subpixel positioning was needed because text layout was performed at 1x device scale factor and then rastered to the final display device scale factor leading to glyph artifacts and inconsistent glyph positioning. With pixel canvas enabled on chrome os, the text layout is now always performed at the final display device scale factor. This, coupled with the replacement of ui scale with display zoom, the text on Chrome OS is now always rastered with the correct glyph positioning and it no longer requires subpixel positioning. Bug:835187,824154, 716662 Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 Component: Text render, subpixel positioning, font TBR=derat@chromium.org Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 Reviewed-on: https://chromium-review.googlesource.com/1026636 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553353} [modify] https://crrev.com/e3cf0f7886f3174453e3101bb7d7c3057e761c33/ui/gfx/font_render_params_linux.cc
,
Apr 24 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a0a2bf50e63646a399c75fc4af662e82d75814a commit 1a0a2bf50e63646a399c75fc4af662e82d75814a Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Apr 25 00:37:12 2018 Revert "Disable subpixel positioning on chrome os" This reverts commit e3cf0f7886f3174453e3101bb7d7c3057e761c33. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable subpixel positioning on chrome os > > Subpixel positioning was needed because text layout was performed at 1x > device scale factor and then rastered to the final display device scale > factor leading to glyph artifacts and inconsistent glyph positioning. > With pixel canvas enabled on chrome os, the text layout is now always > performed at the final display device scale factor. This, coupled with > the replacement of ui scale with display zoom, the text on Chrome OS > is now always rastered with the correct glyph positioning and it no > longer requires subpixel positioning. > > Bug:835187,824154, 716662 > Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 > Component: Text render, subpixel positioning, font > > TBR=derat@chromium.org > > Change-Id: Idc0d6c7851308cc26b1d90f74a619e90dadf0112 > Reviewed-on: https://chromium-review.googlesource.com/1026636 > Reviewed-by: Malay Keshav <malaykeshav@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553353} TBR=derat@chromium.org,malaykeshav@chromium.org Change-Id: I22601786db33c0082480a09e9e7a3905a56a1383 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835187, 824154, 716662 Reviewed-on: https://chromium-review.googlesource.com/1026438 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553392} [modify] https://crrev.com/1a0a2bf50e63646a399c75fc4af662e82d75814a/ui/gfx/font_render_params_linux.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7df6fa77f0a72173b9bacde5ecaf22ee8b5285b commit c7df6fa77f0a72173b9bacde5ecaf22ee8b5285b Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Apr 25 20:54:00 2018 Disable subpixel positioning on chrome os Subpixel positioning was needed because text layout was performed at 1x device scale factor and then rastered to the final display device scale factor leading to glyph artifacts and inconsistent glyph positioning. With pixel canvas enabled on chrome os, the text layout is now always performed at the final display device scale factor. This, coupled with the replacement of ui scale with display zoom, the text on Chrome OS is now always rastered with the correct glyph positioning and it no longer requires subpixel positioning. Updates unittests. Bug: 835187,824154, 716662 Change-Id: Ibcf6314321777da81335769927d65d52911855df Component: Text render, subpixel positioning, font Reviewed-on: https://chromium-review.googlesource.com/1027005 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553738} [modify] https://crrev.com/c7df6fa77f0a72173b9bacde5ecaf22ee8b5285b/ash/display/display_manager_unittest.cc [modify] https://crrev.com/c7df6fa77f0a72173b9bacde5ecaf22ee8b5285b/ui/gfx/font_render_params_linux.cc [modify] https://crrev.com/c7df6fa77f0a72173b9bacde5ecaf22ee8b5285b/ui/gfx/font_render_params_linux_unittest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pucchakayala@chromium.org
, Apr 28 2017